Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 5653480979038208: Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates (Closed)
Patch Set: Added a unit test. Changed the global object injection routine. Created June 10, 2015, 8:42 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -211,6 +211,17 @@
*/
void SetLogSystem(LogSystemPtr val);
+ /**
+ * Gets the global Javascript object, which contains objects that can be
+ * accessed by all the scripts.
+ * @param The `JsValuePtr` to use
Eric 2015/06/10 17:48:16 @param is for the following function, not this one
+ */
+ JsValuePtr GetGlobalJsObject();
+
+ /**
+ * See GetGlobalJsObject()
+ */
+ void SetGlobalJsObject(JsValuePtr globalJsObject);
Eric 2015/06/10 17:48:16 SetGlobalJsObject() is never called. It probably
private:
JsEngine();
@@ -220,6 +231,7 @@
v8::Isolate* isolate;
V8ValueHolder<v8::Context> context;
EventMap eventCallbacks;
+ JsValuePtr globalJsObject;
};
}

Powered by Google App Engine
This is Rietveld