Issue 2237 - Added unit tests for notification opt-out

chrome/content/tests/notification.js

 (function()
 {
   let testRunner = null;
   let randomResult = 0.5;
 
   let originalInfo;
   let info = require("info");
 
   module("Notification handling",
   {
@@ skipping 15 matching lines @@
 
       info.addonName = "adblockpluschrome";
       info.addonVersion = "1.4.1";
       info.application = "chrome";
       info.applicationVersion = "27.0";
       info.platform = "chromium";
       info.platformVersion = "12.0";
 
       Prefs.notificationurl = "http://example.com/notification.json";
       Prefs.notificationdata = {};
+      Prefs.notifications_ignoredcategories = [];
 
       // Replace Math.random() function
       let DownloaderGlobal = Cu.getGlobalForObject(getModuleGlobal("downloader"));
       this._origRandom = DownloaderGlobal.Math.random;
       DownloaderGlobal.Math.random = () => randomResult;
       randomResult = 0.5;
     },
 
     teardown: function()
     {
@@ skipping 323 matching lines @@
       subdomainURLFilter
     ]);
     testRunner.runScheduledTasks(1);
 
     deepEqual(Notification.getNextToShow(), withoutURLFilter, "URL-specific notifications are skipped");
     deepEqual(Notification.getNextToShow("http://foo.com"), withURLFilterFoo, "URL-specific notification is retrieved");
     deepEqual(Notification.getNextToShow("http://foo.com"), null, "URL-specific notification is not retrieved");
     deepEqual(Notification.getNextToShow("http://www.example.com"), subdomainURLFilter, "URL-specific notification matches subdomain");
   });
 
+  test("Global opt-out", function()
+  {
+    Prefs.notifications_showui = false;
+
+    Notification.toggleIgnoreCategory("*", true);
+
+    ok(Prefs.notifications_showui, "Opt-out UI will be shown after opt-out");
+
+    let information = fixConstructors({
+      id: 1,
+      type: "information"
+    });
+    let critical = fixConstructors({
+      id: 2,
+      type: "critical"
+    });
+
+    registerHandler([information]);
+    testRunner.runScheduledTasks(1);
+
+    deepEqual(Notification.getNextToShow(), null, "Information notifications are ignored");
+
+    Prefs.notificationdata = {};
+    registerHandler([critical]);
+    testRunner.runScheduledTasks(1);
+
+    deepEqual(Notification.getNextToShow(), critical, "Critical notifications are not ignored");

[Wladimir Palant, 2015/05/26 11:23:19]

This test is incomplete. Following scenarios need to be tested as well:

* Notification.toggleIgnoreCategory("*", true) with category already ignored.
* Notification.toggleIgnoreCategory("*", false) with category ignored.
* Notification.toggleIgnoreCategory("*", false) with category not ignored.
* Notification.toggleIgnoreCategory("*") both with category ignored and not
ignored.
* notifications_showui behavior: doesn't change when the category is toggled off
(both for initial value true and false).
* informational notification is shown again once the category is toggled off.

[Thomas Greiner, 2015/05/28 13:24:18]

Done, thanks for the additions.

Note that the existing tests covered everything that was described in the review
description.

+  });
+
   module("Notification localization");
 
   test("Message without localization", function()
   {
     let notification = {message: "non-localized"};
     let texts = Notification.getLocalizedTexts(notification, "en-US");
     equal(texts.message, "non-localized");
   });
 
   test("Language only", function()
@@ skipping 14 matching lines @@
     equal(texts.message, "fr");
   });
 
   test("Missing translation", function()
   {
     let notification = {message: {"en-US": "en-US"}};
     let texts = Notification.getLocalizedTexts(notification, "fr");
     equal(texts.message, "en-US");
   });
 })();