Issue 2237 - Added unit tests for notification opt-out

chrome/content/tests/notification.js

 (function()
 {
   let testRunner = null;
   let randomResult = 0.5;
 
   let originalInfo;
   let info = require("info");
 
   module("Notification handling",
   {
@@ skipping 361 matching lines @@
     testRunner.runScheduledTasks(1);
 
     deepEqual(Notification.getNextToShow(), withoutURLFilter, "URL-specific notifications are skipped");
     deepEqual(Notification.getNextToShow("http://foo.com"), withURLFilterFoo, "URL-specific notification is retrieved");
     deepEqual(Notification.getNextToShow("http://foo.com"), null, "URL-specific notification is not retrieved");
     deepEqual(Notification.getNextToShow("http://www.example.com"), subdomainURLFilter, "URL-specific notification matches subdomain");
   });
 
   test("Global opt-out", function()
   {
+    Notification.toggleIgnoreCategory("*", true);
+    ok(Prefs.notifications_ignoredcategories.indexOf("*") != -1, "Force enable global opt-out");
+    Notification.toggleIgnoreCategory("*", true);
+    ok(Prefs.notifications_ignoredcategories.indexOf("*") != -1, "Force enable global opt-out (again)");
+    Notification.toggleIgnoreCategory("*", false);
+    ok(Prefs.notifications_ignoredcategories.indexOf("*") == -1, "Force disable global opt-out");
+    Notification.toggleIgnoreCategory("*", false);
+    ok(Prefs.notifications_ignoredcategories.indexOf("*") == -1, "Force disable global opt-out (again)");
+    Notification.toggleIgnoreCategory("*");
+    ok(Prefs.notifications_ignoredcategories.indexOf("*") != -1, "Toggle enable global opt-out");
+    Notification.toggleIgnoreCategory("*");
+    ok(Prefs.notifications_ignoredcategories.indexOf("*") == -1, "Toggle disable global opt-out");
+
     Prefs.notifications_showui = false;
-
+    Notification.toggleIgnoreCategory("*", false);
+    ok(!Prefs.notifications_showui, "Opt-out UI will not be shown if global opt-out hasn't been enabled yet");
     Notification.toggleIgnoreCategory("*", true);
-
-    ok(Prefs.notifications_showui, "Opt-out UI will be shown after opt-out");
+    ok(Prefs.notifications_showui, "Opt-out UI will be shown after enabling global opt-out");
+    Notification.toggleIgnoreCategory("*", false);
+    ok(Prefs.notifications_showui, "Opt-out UI will be shown after enabling global opt-out even if it got disabled again");
 
     let information = fixConstructors({
       id: 1,
       type: "information"
     });
     let critical = fixConstructors({
       id: 2,
       type: "critical"
     });
 
+    Notification.toggleIgnoreCategory("*", true);
     registerHandler([information]);
     testRunner.runScheduledTasks(1);
 
-    deepEqual(Notification.getNextToShow(), null, "Information notifications are ignored");
-
+    deepEqual(Notification.getNextToShow(), null, "Information notifications are ignored after enabling global opt-out");
+    Notification.toggleIgnoreCategory("*", false);
+    deepEqual(Notification.getNextToShow(), information, "Information notifications are shown after disabling global opt-out");
+
+    Notification.toggleIgnoreCategory("*", true);
     Prefs.notificationdata = {};
     registerHandler([critical]);
     testRunner.runScheduledTasks(1);
 
     deepEqual(Notification.getNextToShow(), critical, "Critical notifications are not ignored");

[Wladimir Palant, 2015/05/26 11:23:19]

This test is incomplete. Following scenarios need to be tested as well:

* Notification.toggleIgnoreCategory("*", true) with category already ignored.
* Notification.toggleIgnoreCategory("*", false) with category ignored.
* Notification.toggleIgnoreCategory("*", false) with category not ignored.
* Notification.toggleIgnoreCategory("*") both with category ignored and not
ignored.
* notifications_showui behavior: doesn't change when the category is toggled off
(both for initial value true and false).
* informational notification is shown again once the category is toggled off.

[Thomas Greiner, 2015/05/28 13:24:18]

Done, thanks for the additions.

Note that the existing tests covered everything that was described in the review
description.

   });
 
   module("Notification localization");
 
   test("Message without localization", function()
   {
     let notification = {message: "non-localized"};
     let texts = Notification.getLocalizedTexts(notification, "en-US");
     equal(texts.message, "non-localized");
   });
@@ skipping 16 matching lines @@
     equal(texts.message, "fr");
   });
 
   test("Missing translation", function()
   {
     let notification = {message: {"en-US": "en-US"}};
     let texts = Notification.getLocalizedTexts(notification, "fr");
     equal(texts.message, "en-US");
   });
 })();