Issue 236 - Development build changelogs cannot deal with Unicode

sitescripts/extensions/bin/createNightlies.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 55 matching lines @@
     """
     command = ['hg', 'log', '-R', self.config.repository, '-r', 'default', '--template', '{rev}']
     return subprocess.check_output(command)
 
   def getChanges(self):
     """
       retrieve changes between the current and previous ("first") revision
     """
 
     command = ['hg', 'log', '-R', self.config.repository, '-r', 'tip:0',
-      '-b', 'default', '-l', '50',
+      '-b', 'default', '-l', '50', '--encoding', 'utf-8',
       '--template', '{date|isodate}\\0{author|person}\\0{rev}\\0{desc}\\0\\0']
-    result = subprocess.check_output(command)
+    result = subprocess.check_output(command).decode('utf-8')
 
     for change in result.split('\0\0'):
       if change:
         date, author, revision, description = change.split('\0')
         yield {'date': date, 'author': author, 'revision': revision, 'description': description}
 
   def copyRepository(self):
     '''
       Create a repository copy in a temporary directory
     '''
     # We cannot use hg archive here due to
     # http://bz.selenic.com/show_bug.cgi?id=3747, have to clone properly :-(
     self.tempdir = tempfile.mkdtemp(prefix=self.config.repositoryName)
     command = ['hg', 'clone', '-q', self.config.repository, '-u', 'default', self.tempdir]
     subprocess.check_call(command)
 
   def writeChangelog(self, changes):
     """
       write the changelog file into the cloned repository
     """
     baseDir = os.path.join(self.config.nightliesDirectory, self.basename)
     if not os.path.exists(baseDir):
       os.makedirs(baseDir)
     changelogFile = "%s-%s.changelog.xhtml" % (self.basename, self.version)
     changelogPath = os.path.join(baseDir, changelogFile)
     self.changelogURL = urlparse.urljoin(self.config.nightliesURL, self.basename + '/' + changelogFile)
 
     template = get_template(get_config().get('extensions', 'changelogTemplate'))
-    template.stream({'changes': changes}).dump(changelogPath)
+    template.stream({'changes': changes}).dump(changelogPath, encoding='utf-8')
 
     linkPath = os.path.join(baseDir, '00latest.changelog.xhtml')
     if hasattr(os, 'symlink'):
       if os.path.exists(linkPath):
         os.remove(linkPath)
       os.symlink(os.path.basename(changelogPath), linkPath)
     else:
       shutil.copyfile(changelogPath, linkPath)
 
   def readGeckoMetadata(self):
@@ skipping 387 matching lines @@
     except Exception, ex:
       print >>sys.stderr, "The build for %s failed:" % repo
       traceback.print_exc()
 
   file = open(nightlyConfigFile, 'wb')
   nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
   main()