Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5663214012465152: Issue 2467 - Ingore inner quotes when parsing CSS selectors (Closed)

Created:
May 7, 2015, 3:25 p.m. by Sebastian Noack
Modified:
May 15, 2015, 11:35 a.m.
Reviewers:
Thomas Greiner
CC:
Wladimir Palant, kzar
Visibility:
Public.

Description

Issue 2467 - Ingore inner quotes when parsing CSS selectors

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M include.preload.js View 1 chunk +8 lines, -5 lines 6 comments Download

Messages

Total messages: 8
Sebastian Noack
May 7, 2015, 3:26 p.m. (2015-05-07 15:26:30 UTC) #1
Sebastian Noack
May 7, 2015, 3:47 p.m. (2015-05-07 15:47:28 UTC) #2
Thomas Greiner
LGTM Note that, at the moment, not a single filter in EasyList or EasyListGermany contains ...
May 7, 2015, 5:42 p.m. (2015-05-07 17:42:57 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js#newcode156 include.preload.js:156: for (var j = 0; j < selector.length; j++) ...
May 7, 2015, 6:59 p.m. (2015-05-07 18:59:40 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js#newcode156 include.preload.js:156: for (var j = 0; j < selector.length; j++) ...
May 7, 2015, 7:17 p.m. (2015-05-07 19:17:21 UTC) #5
Thomas Greiner
http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js#newcode156 include.preload.js:156: for (var j = 0; j < selector.length; j++) ...
May 8, 2015, 5:03 p.m. (2015-05-08 17:03:24 UTC) #6
Sebastian Noack
http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/include.preload.js#newcode156 include.preload.js:156: for (var j = 0; j < selector.length; j++) ...
May 8, 2015, 5:21 p.m. (2015-05-08 17:21:28 UTC) #7
Sebastian Noack
May 15, 2015, 11:35 a.m. (2015-05-15 11:35:21 UTC) #8
http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5663214012465152/diff/5629499534213120/incl...
include.preload.js:156: for (var j = 0; j < selector.length; j++)
On 2015/05/07 17:42:58, Thomas Greiner wrote:
> This loop is only necessary if there's a `,` in the string and since that's
only
> the case for less than 0.5% of element hiding filters in EasyListGermany it
> seems to be well worth checking for it in advance.
> 
> Not really related to this issue though so we can tackle this in a separate
> ticket.

There you go: http://codereview.adblockplus.org/4759827771293696/

Powered by Google App Engine
This is Rietveld