Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5664054114779136: Issue 2350 - Remove Add-ons, Apps and Sync (Closed)

Created:
April 21, 2015, 9:50 a.m. by René Jeschke
Modified:
May 28, 2015, 7:31 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 2350 - Remove Add-ons, Apps and Sync

Patch Set 1 #

Patch Set 2 : Removed ID refs for removed entries #

Patch Set 3 : Removed sync from xml-v11, too #

Total comments: 3

Patch Set 4 : Hide instead of remove, comments #

Total comments: 1

Patch Set 5 : Moved visible attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M mobile/android/base/resources/menu-large-v11/browser_app_menu.xml View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M mobile/android/base/resources/menu-v11/browser_app_menu.xml View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M mobile/android/base/resources/menu/browser_app_menu.xml View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M mobile/android/base/resources/xml-v11/preferences.xml View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M mobile/android/base/resources/xml/preferences.xml View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11
René Jeschke
April 21, 2015, 9:50 a.m. (2015-04-21 09:50:47 UTC) #1
René Jeschke
*argh* ... this does not work^^ Will up a working solution soon, sry :-D
April 21, 2015, 9:52 a.m. (2015-04-21 09:52:44 UTC) #2
René Jeschke
So, had to remove the references to the (now) missing items from BrowserApp, works now.
April 21, 2015, 9:59 a.m. (2015-04-21 09:59:45 UTC) #3
René Jeschke
And, just a remark for Sync: There is a code line, that removes sync programmatically ...
April 21, 2015, 12:37 p.m. (2015-04-21 12:37:20 UTC) #4
Felix Dahlke
http://codereview.adblockplus.org/5664054114779136/diff/5757334940811264/mobile/android/base/BrowserApp.java File mobile/android/base/BrowserApp.java (right): http://codereview.adblockplus.org/5664054114779136/diff/5757334940811264/mobile/android/base/BrowserApp.java#newcode2577 mobile/android/base/BrowserApp.java:2577: // Removed R.id.apps and R.id.addons as of issue #2350 ...
April 22, 2015, 1:29 p.m. (2015-04-22 13:29:59 UTC) #5
René Jeschke
Done.
April 23, 2015, 3:05 p.m. (2015-04-23 15:05:00 UTC) #6
Felix Dahlke
http://codereview.adblockplus.org/5664054114779136/diff/5733935958982656/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml File mobile/android/base/resources/menu-large-v11/browser_app_menu.xml (right): http://codereview.adblockplus.org/5664054114779136/diff/5733935958982656/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml#newcode88 mobile/android/base/resources/menu-large-v11/browser_app_menu.xml:88: android:visible="false" /> The "visible" attribute generally seems to come ...
April 23, 2015, 4:07 p.m. (2015-04-23 16:07:33 UTC) #7
René Jeschke
On 2015/04/23 16:07:33, Felix H. Dahlke wrote: > http://codereview.adblockplus.org/5664054114779136/diff/5733935958982656/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml > File mobile/android/base/resources/menu-large-v11/browser_app_menu.xml (right): > > ...
April 23, 2015, 8:27 p.m. (2015-04-23 20:27:41 UTC) #8
Felix Dahlke
LGTM On 2015/04/23 20:27:41, René Jeschke wrote: > On 2015/04/23 16:07:33, Felix H. Dahlke wrote: ...
April 23, 2015, 8:34 p.m. (2015-04-23 20:34:12 UTC) #9
Felix Dahlke
Assuming this isn't pushed yet - I just realised it makes more sense to commit ...
April 24, 2015, 5:46 a.m. (2015-04-24 05:46:54 UTC) #10
Felix Dahlke
April 25, 2015, 6:22 p.m. (2015-04-25 18:22:18 UTC) #11
On 2015/04/24 05:46:54, Felix H. Dahlke wrote:
> Assuming this isn't pushed yet - I just realised it makes more sense to commit
> removing Add-ons, Apps and Sync in three separate commits. We're quite unlike
to
> enable them all at the same time again. (Three reviews/commits linked to that
> one issue will do.)

Actually, I've split this up into three issues - shouldn't have lumped it
together in the first place. It's quite likely that we will revert these changes
individually...

Powered by Google App Engine
This is Rietveld