Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(240)

Issue 5664713014771712: Issue 581 - Run content scripts also in anonymous frames on Chrome 37+ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by Sebastian Noack
Modified:
5 years, 7 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 581 - Run content scripts also in anonymous frames on Chrome 37+

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M packagerChrome.py View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 3
Sebastian Noack
5 years, 7 months ago (2014-06-02 10:23:02 UTC) #1
Wladimir Palant
LGTM assuming that this change is backwards-compatible, good to merge for the release tomorrow as ...
5 years, 7 months ago (2014-06-02 10:57:11 UTC) #2
Sebastian Noack
5 years, 7 months ago (2014-06-02 11:48:27 UTC) #3
http://codereview.adblockplus.org/5664713014771712/diff/5668600916475904/pack...
File packagerChrome.py (right):

http://codereview.adblockplus.org/5664713014771712/diff/5668600916475904/pack...
packagerChrome.py:117: 'match_about_blank': True,
On 2014/06/02 10:57:11, Wladimir Palant wrote:
> Is that change backwards-compatible? Meaning: will that extension install in
> current Chrome versions?

Yes. Tested with Chrome 34.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5