Issue 581 - Fixed element hiding/collapsing in anonymous frames on Chrome

include.preload.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 47 matching lines @@
   }
 }
 
 function checkExceptionKey()
 {
   var attr = document.documentElement.getAttribute("data-adblockkey");
   if (attr)
     ext.backgroundPage.sendMessage({type: "add-key-exception", token: attr});
 }
 
+function hasInlineURL(element, attribute)
+{
+  var value = element.getAttribute(attribute);
+  return value == null || /^\s*(javascript:|about:|$)/i.test(value);
+}
+
+function isInlineFrame(element)
+{
+  switch (element.localName)
+  {
+    case "iframe":
+      return hasInlineURL(element, "src") || element.hasAttribute("srcdoc");
+    case "frame":
+      return hasInlineURL(element, "src");
+    case "object":
+      return hasInlineURL(element, "data") && element.contentDocument;
+    default:
+      return false;
+  }
+}
+
 // Converts relative to absolute URL
 // e.g.: foo.swf on http://example.com/whatever/bar.html
 //  -> http://example.com/whatever/foo.swf
 function relativeToAbsoluteUrl(url)
 {
   // If URL is already absolute, don't mess with it
   if (!url || /^[\w\-]+:/i.test(url))
     return url;
 
   // Leading / means absolute path
@@ skipping 105 matching lines @@
   document.addEventListener("error", function(event)
   {
     checkCollapse(event.target);
   }, true);
 
   document.addEventListener("load", function(event)
   {
     var element = event.target;
 
     if (/^i?frame$/.test(element.localName))
-    {
       checkCollapse(element);
 
-      if (fixInlineFrames && (element.hasAttribute("srcdoc") || !element.hasAttribute("src") ||
-                              /^\s*(javascript:|about:|$)/i.test(element.getAttribute("src"))))

[Wladimir Palant, 2014/06/04 14:12:49]

What about data: URLs? Note that checking whether it is an HTML document is
still necessary for those.

Also, could you check whether/how we need to handle <object data="about:blank"
type="text/html">?

[Sebastian Noack, 2014/06/04 16:12:30]

This check intentionally don't match data: URLs, since we can't do anything for
them, due to cross-domain policy.
Thanks for pointing this one out. After some testing I can confirm that <object
type="text/html"> elements are handled the same as frames. Content scripts are
only injected when pointing to an external document before Chrome 37. If the
"data" attribute is missing, empty or using either an about: or javascript: URL,
an empty DOM is created which can be accessed via contentDocument.

-      {
-        var contentDocument = element.contentDocument;
-        init(contentDocument);

[Wladimir Palant, 2014/06/04 14:12:49]

Nit: It seems that the contentDocument variable is pointless now.

[Sebastian Noack, 2014/06/04 16:12:30]

Done.

-
-        for (var tagName in typeMap)
-          Array.prototype.forEach.call(contentDocument.getElementsByTagName(tagName), checkCollapse);
-      }
+    if (fixInlineFrames && isInlineFrame(element))
+    {
+      init(element.contentDocument);
+
+      for (var tagName in typeMap)
+        Array.prototype.forEach.call(element.contentDocument.getElementsByTagName(tagName), checkCollapse);
     }
   }, true);
 
   ext.backgroundPage.sendMessage({type: "get-selectors"}, setElemhideCSSRules);
 }
 
 if (document.documentElement instanceof HTMLElement)
 {
   checkExceptionKey();
   init(document);
 }