Fixed properties defined on prototype in Safari background page proxy

safari/ext/content.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 120 matching lines @@
       if (!result.succeed)
         throw result.error;
     },
     deserializeResult: function(result)
     {
       this.checkResult(result);
       return this.deserialize(result.result);
     },
     serialize: function(obj, memo)
     {
-      var objectId = this.objects.indexOf(obj);
-      if (objectId != -1)
-        return {type: "hosted", objectId: objectId};
+      if ((typeof obj == "object" || typeof obj == "function") && obj != null)
+      {
+        if ("__proxyObjectId" in obj)
+          return {type: "hosted", objectId: obj.__proxyObjectId};
 
-      if (typeof obj == "function")
-      {
-        var callbackId = this.callbacks.indexOf(obj);
-        if (callbackId == -1)
-          callbackId = this.callbacks.push(obj) - 1;
+        if (typeof obj == "function")
+        {
+          var callbackId;
+          if ("__proxyCallbackId" in obj)
+            callbackId = obj.__proxyCallbackId;
+          else
+          {
+            callbackId = this.callbacks.push(obj) - 1;
+            Object.defineProperty(obj, "__proxyCallbackId", {value: callbackId});
+          }
 
-        return {type: "callback", callbackId: callbackId, frameId: documentInfo.frameId};
-      }
-
-      if (typeof obj == "object" &&
-          obj != null &&
-          obj.constructor != Date &&
-          obj.constructor != RegExp)
-      {
-        if (!memo)
-          memo = {specs: [], objects: []};
-
-        var idx = memo.objects.indexOf(obj);
-        if (idx != -1)
-          return memo.specs[idx];
-
-        var spec = {};
-        memo.specs.push(spec);
-        memo.objects.push(obj);
-
-        if (obj.constructor == Array)
-        {
-          spec.type = "array";
-          spec.items = [];
-
-          for (var i = 0; i < obj.length; i++)
-            spec.items.push(this.serialize(obj[i], memo));
-        }
-        else
-        {
-          spec.type = "object";
-          spec.properties = {};
-
-          for (var k in obj)
-            spec.properties[k] = this.serialize(obj[k], memo);
+          return {type: "callback", callbackId: callbackId, frameId: documentInfo.frameId};
         }
 
-        return spec;
+        if (obj.constructor != Date && obj.constructor != RegExp)
+        {
+          if (!memo)
+            memo = {specs: [], objects: []};
+
+          var idx = memo.objects.indexOf(obj);
+          if (idx != -1)
+            return memo.specs[idx];
+
+          var spec = {};
+          memo.specs.push(spec);
+          memo.objects.push(obj);
+
+          if (obj.constructor == Array)
+          {
+            spec.type = "array";
+            spec.items = [];
+
+            for (var i = 0; i < obj.length; i++)
+              spec.items.push(this.serialize(obj[i], memo));
+          }
+          else
+          {
+            spec.type = "object";
+            spec.properties = {};
+
+            for (var k in obj)
+              spec.properties[k] = this.serialize(obj[k], memo);
+          }
+
+          return spec;
+        }
       }
 
       return {type: "value", value: obj};
     },
     deserializeSequence: function(specs, array, memo)
     {
       if (!array)
         array = [];
 
       if (!memo)
@@ skipping 20 matching lines @@
           if (idx != -1)
             return memo.arrays[idx];
 
           var array = [];
           memo.specs.push(spec);
           memo.arrays.push(array);
 
           return this.deserializeSequence(spec.items, array, memo);
       }
     },
-    getObjectId: function(obj)
-    {
-      return this.objects.indexOf(obj);
-    },
     getProperty: function(objectId, property)
     {
       return this.deserializeResult(
         this.send(
         {
           type: "getProperty",
           objectId: objectId,
           property: property
         })
       );
     },
     createProperty: function(property, enumerable)
     {
       var proxy = this;
       return {
         get: function()
         {
-          return proxy.getProperty(proxy.getObjectId(this), property);
+          return proxy.getProperty(this.__proxyObjectId, property);
         },
         set: function(value)
         {
           proxy.checkResult(
             proxy.send(
             {
               type: "setProperty",
-              objectId: proxy.getObjectId(this),
+              objectId: this.__proxyObjectId,
               property: property,
               value: proxy.serialize(value)
             })
           );
         },
         enumerable: enumerable,
         configurable: true
       };
     },
     createFunction: function(objectId)
     {
       var proxy = this;
       return function()
       {
         return proxy.deserializeResult(
           proxy.send(
           {
             type: "callFunction",
             functionId: objectId,
-            contextId: proxy.getObjectId(this),
+            contextId: this.__proxyObjectId,
             args: Array.prototype.map.call(
               arguments,
               proxy.serialize.bind(proxy)
             )
           })
         );
       };
     },
     handleCallback: function(message)
     {
@@ skipping 13 matching lines @@
       if (obj)
         Object.getOwnPropertyNames(obj).forEach(function(prop) { delete obj[prop]; });
       else
       {
         if (objectInfo.isFunction)
           obj = this.createFunction(objectId);
         else
           obj = {};
 
         this.objects[objectId] = obj;
+        Object.defineProperty(obj, "__proxyObjectId", {value: objectId});
       }
 
       var ignored = [];
       if ("prototypeOf" in objectInfo)
       {
         var prototype = window[objectInfo.prototypeOf].prototype;
 
         ignored = Object.getOwnPropertyNames(prototype);
         ignored.splice(ignored.indexOf("constructor"), 1);
 
         obj.__proto__ = prototype;
       }
       else
       {
         if (objectInfo.isFunction)
           ignored = Object.getOwnPropertyNames(function() {});
         else
           ignored = [];
 
         if ("prototypeId" in objectInfo)
           obj.__proto__ = this.getObject(objectInfo.prototypeId);
         else
           obj.__proto__ = null;
       }
 
       for (var property in objectInfo.properties)
+      {
         if (ignored.indexOf(property) == -1)
-          Object.defineProperty(obj, property, this.createProperty(
-            property, objectInfo.properties[property].enumerable
-          ));
+        {
+          var desc = Object.getOwnPropertyDescriptor(obj, property);
 
-      if (objectInfo.isFunction)
-        obj.prototype = this.getProperty(objectId, "prototype");
+          if (!desc || desc.configurable)
+          {
+            Object.defineProperty(obj, property, this.createProperty(
+              property, objectInfo.properties[property].enumerable
+            ));
+          }
+          else if (desc.writable)
+            obj[property] = this.getProperty(objectId, property);
+        }
+      }
 
       return obj;
     }
   };
 
   ext.backgroundPage = {
     sendMessage: function(message, responseCallback)
     {
       messageProxy.sendMessage(message, responseCallback, documentInfo);
     },
@@ skipping 26 matching lines @@
             messageProxy.handleResponse(event.message);
             break;
           case "proxyCallback":
             backgroundPageProxy.handleCallback(event.message);
             break;
         }
       }
     }
   });
 })();