Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 5676337998069760: wrong icons parameter value in manifest.json for chrome main repo fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by saroyanm
Modified:
5 years, 11 months ago
Reviewers:
Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

This fix is related to current ticket: https://issues.adblockplus.org/ticket/156 Relative review: http://codereview.adblockplus.org/5406295150559232

Patch Set 1 #

Total comments: 2

Patch Set 2 : Icon 19px changed to 16px, mapping section added #

Patch Set 3 : moveed icon abp-16.png to icons folder #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M icons/abp-16.png View 1 2 Binary file 0 comments Download
M metadata.chrome View 1 2 4 chunks +6 lines, -4 lines 1 comment Download
M metadata.safari View 1 2 1 chunk +19 lines, -19 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
http://codereview.adblockplus.org/5676337998069760/diff/5629499534213120/metadata.chrome File metadata.chrome (right): http://codereview.adblockplus.org/5676337998069760/diff/5629499534213120/metadata.chrome#newcode17 metadata.chrome:17: icons = icons/abp-19.png icons/abp-48.png icons/abp-128.png Please see http://developer.chrome.com/extensions/manifest/icons, the ...
5 years, 11 months ago (2014-03-18 17:18:28 UTC) #1
saroyanm
New patch uploaded. http://codereview.adblockplus.org/5676337998069760/diff/5629499534213120/metadata.chrome File metadata.chrome (right): http://codereview.adblockplus.org/5676337998069760/diff/5629499534213120/metadata.chrome#newcode17 metadata.chrome:17: icons = icons/abp-19.png icons/abp-48.png icons/abp-128.png On ...
5 years, 11 months ago (2014-03-19 09:07:37 UTC) #2
saroyanm
On 2014/03/19 09:07:37, saroyanm wrote: > New patch uploaded. > > http://codereview.adblockplus.org/5676337998069760/diff/5629499534213120/metadata.chrome > File metadata.chrome ...
5 years, 11 months ago (2014-03-19 09:21:20 UTC) #3
Wladimir Palant
LGTM with my comment below addressed. http://codereview.adblockplus.org/5676337998069760/diff/5717271485874176/metadata.chrome File metadata.chrome (right): http://codereview.adblockplus.org/5676337998069760/diff/5717271485874176/metadata.chrome#newcode17 metadata.chrome:17: icons = icons/abp-16.png ...
5 years, 11 months ago (2014-03-19 12:20:08 UTC) #4
saroyanm
5 years, 11 months ago (2014-03-20 07:05:04 UTC) #5
On 2014/03/19 12:20:08, Wladimir Palant wrote:
> LGTM with my comment below addressed.
> 
>
http://codereview.adblockplus.org/5676337998069760/diff/5717271485874176/meta...
> File metadata.chrome (right):
> 
>
http://codereview.adblockplus.org/5676337998069760/diff/5717271485874176/meta...
> metadata.chrome:17: icons = icons/abp-16.png icons/abp-48.png
icons/abp-128.png
> I was about to ask whether we need abp-32.png in the icons folder. However,
from
> https://code.google.com/p/chromium/issues/detail?id=94301 it seems that this
> icon size is also being used even though the documentation doesn't mention it.
> So please add it here as well.

That's quite interesting.. Thanks.
pushed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5