Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: metadata.chrome

Issue 5676337998069760: wrong icons parameter value in manifest.json for chrome main repo fix (Closed)
Left Patch Set: Created March 18, 2014, 4:07 p.m.
Right Patch Set: moveed icon abp-16.png to icons folder Created March 19, 2014, 9:12 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « icons/abp-16.png ('k') | metadata.safari » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 [default] 1 [default]
2 inherit = metadata.common 2 inherit = metadata.common
3 3
4 [general] 4 [general]
5 basename = adblockpluschrome 5 basename = adblockpluschrome
6 permissions = tabs 6 permissions = tabs
7 http://*/* 7 http://*/*
8 https://*/* 8 https://*/*
9 contextMenus 9 contextMenus
10 webRequest 10 webRequest
11 webRequestBlocking 11 webRequestBlocking
12 webNavigation 12 webNavigation
13 unlimitedStorage 13 unlimitedStorage
14 notifications 14 notifications
15 options = options.html 15 options = options.html
16 browserAction = icons/abp-19.png popup.html 16 browserAction = icons/abp-19.png popup.html
17 icons = icons/abp-19.png icons/abp-48.png icons/abp-128.png 17 icons = icons/abp-16.png icons/abp-48.png icons/abp-128.png
Wladimir Palant 2014/03/18 17:18:29 Please see http://developer.chrome.com/extensions/
saroyanm 2014/03/19 09:07:37 How I could be that inattentive, Thanks on pointin
Wladimir Palant 2014/03/19 12:20:09 I was about to ask whether we need abp-32.png in t
18 webAccessible = block.html icons/abp-128.png 18 webAccessible = block.html icons/abp-128.png
19 19
20 [compat] 20 [compat]
21 chrome = 18.0 21 chrome = 18.0
22 22
23 [convert_js] 23 [convert_js]
24 lib/io.js = lib/filesystem/io.js 24 lib/io.js = lib/filesystem/io.js
25 --arg module=true 25 --arg module=true
26 26
27 [convert_img] 27 [mapping]
28 icons/abp-19.png = chrome/icons/abp-19.png 28 icons/abp-19.png = chrome/icons/abp-19.png
29 icons/abp-19-notification-critical.png = chrome/icons/abp-19-notification-critic al.png 29 icons/abp-19-notification-critical.png = chrome/icons/abp-19-notification-critic al.png
30 icons/abp-19-notification-information.png = chrome/icons/abp-19-notification-inf ormation.png
31 icons/abp-48.png = chrome/icons/abp-48.png
32
33 [convert_img]
30 icons/abp-19-notification-critical-1.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.1) 34 icons/abp-19-notification-critical-1.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.1)
31 icons/abp-19-notification-critical-2.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.2) 35 icons/abp-19-notification-critical-2.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.2)
32 icons/abp-19-notification-critical-3.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.3) 36 icons/abp-19-notification-critical-3.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.3)
33 icons/abp-19-notification-critical-4.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.4) 37 icons/abp-19-notification-critical-4.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.4)
34 icons/abp-19-notification-critical-5.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.5) 38 icons/abp-19-notification-critical-5.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.5)
35 icons/abp-19-notification-critical-6.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.6) 39 icons/abp-19-notification-critical-6.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.6)
36 icons/abp-19-notification-critical-7.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.7) 40 icons/abp-19-notification-critical-7.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.7)
37 icons/abp-19-notification-critical-8.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.8) 41 icons/abp-19-notification-critical-8.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.8)
38 icons/abp-19-notification-critical-9.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.9) 42 icons/abp-19-notification-critical-9.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.9)
39 icons/abp-19-notification-information.png = chrome/icons/abp-19-notification-inf ormation.png
40 icons/abp-19-notification-information-1.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.1) 43 icons/abp-19-notification-information-1.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.1)
41 icons/abp-19-notification-information-2.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.2) 44 icons/abp-19-notification-information-2.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.2)
42 icons/abp-19-notification-information-3.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.3) 45 icons/abp-19-notification-information-3.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.3)
43 icons/abp-19-notification-information-4.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.4) 46 icons/abp-19-notification-information-4.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.4)
44 icons/abp-19-notification-information-5.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.5) 47 icons/abp-19-notification-information-5.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.5)
45 icons/abp-19-notification-information-6.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.6) 48 icons/abp-19-notification-information-6.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.6)
46 icons/abp-19-notification-information-7.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.7) 49 icons/abp-19-notification-information-7.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.7)
47 icons/abp-19-notification-information-8.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.8) 50 icons/abp-19-notification-information-8.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.8)
48 icons/abp-19-notification-information-9.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.9) 51 icons/abp-19-notification-information-9.png = chrome/icons/abp-19.png -> blend(c hrome/icons/abp-19-notification-information.png, 0.9)
49 icons/abp-19-whitelisted.png = chrome/icons/abp-19.png -> blend(255, 255, 255, 0 .2) -> grayscale 52 icons/abp-19-whitelisted.png = chrome/icons/abp-19.png -> blend(255, 255, 255, 0 .2) -> grayscale
50 icons/abp-19-whitelisted-notification-critical-1.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.1) 53 icons/abp-19-whitelisted-notification-critical-1.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.1)
51 icons/abp-19-whitelisted-notification-critical-2.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.2) 54 icons/abp-19-whitelisted-notification-critical-2.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.2)
52 icons/abp-19-whitelisted-notification-critical-3.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.3) 55 icons/abp-19-whitelisted-notification-critical-3.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.3)
53 icons/abp-19-whitelisted-notification-critical-4.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.4) 56 icons/abp-19-whitelisted-notification-critical-4.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.4)
54 icons/abp-19-whitelisted-notification-critical-5.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.5) 57 icons/abp-19-whitelisted-notification-critical-5.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.5)
55 icons/abp-19-whitelisted-notification-critical-6.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.6) 58 icons/abp-19-whitelisted-notification-critical-6.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.6)
56 icons/abp-19-whitelisted-notification-critical-7.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.7) 59 icons/abp-19-whitelisted-notification-critical-7.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.7)
57 icons/abp-19-whitelisted-notification-critical-8.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.8) 60 icons/abp-19-whitelisted-notification-critical-8.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.8)
58 icons/abp-19-whitelisted-notification-critical-9.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.9) 61 icons/abp-19-whitelisted-notification-critical-9.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.9)
59 icons/abp-19-whitelisted-notification-information-1.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.1) 62 icons/abp-19-whitelisted-notification-information-1.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.1)
60 icons/abp-19-whitelisted-notification-information-2.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.2) 63 icons/abp-19-whitelisted-notification-information-2.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.2)
61 icons/abp-19-whitelisted-notification-information-3.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.3) 64 icons/abp-19-whitelisted-notification-information-3.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.3)
62 icons/abp-19-whitelisted-notification-information-4.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.4) 65 icons/abp-19-whitelisted-notification-information-4.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.4)
63 icons/abp-19-whitelisted-notification-information-5.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.5) 66 icons/abp-19-whitelisted-notification-information-5.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.5)
64 icons/abp-19-whitelisted-notification-information-6.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.6) 67 icons/abp-19-whitelisted-notification-information-6.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.6)
65 icons/abp-19-whitelisted-notification-information-7.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.7) 68 icons/abp-19-whitelisted-notification-information-7.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.7)
66 icons/abp-19-whitelisted-notification-information-8.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.8) 69 icons/abp-19-whitelisted-notification-information-8.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.8)
67 icons/abp-19-whitelisted-notification-information-9.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.9) 70 icons/abp-19-whitelisted-notification-information-9.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.9)
68 icons/abp-48.png = chrome/icons/abp-48.png
LEFTRIGHT

Powered by Google App Engine
This is Rietveld