metadata.chrome - Issue 5676337998069760: wrong icons parameter value in manifest.json for chrome main repo fix

Delta Between Two Patch Sets: metadata.chrome

Issue 5676337998069760: wrong icons parameter value in manifest.json for chrome main repo fix (Closed)

Left Patch Set: Icon 19px changed to 16px, mapping section added Created March 19, 2014, 9:06 a.m.

Right Patch Set: moveed icon abp-16.png to icons folder Created March 19, 2014, 9:12 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.common	2 inherit = metadata.common

3	3

4 [general]	4 [general]

5 basename = adblockpluschrome	5 basename = adblockpluschrome

6 permissions = tabs	6 permissions = tabs

7 http:///	7 http:///

8 https:///	8 https:///

9 contextMenus	9 contextMenus

10 webRequest	10 webRequest

11 webRequestBlocking	11 webRequestBlocking

12 webNavigation	12 webNavigation

13 unlimitedStorage	13 unlimitedStorage

14 notifications	14 notifications

15 options = options.html	15 options = options.html

16 browserAction = icons/abp-19.png popup.html	16 browserAction = icons/abp-19.png popup.html

17 icons = icons/abp-16.png icons/abp-48.png icons/abp-128.png	17 icons = icons/abp-16.png icons/abp-48.png icons/abp-128.png
	Wladimir Palant 2014/03/19 12:20:09 I was about to ask whether we need abp-32.png in t I was about to ask whether we need abp-32.png in the icons folder. However, from https://code.google.com/p/chromium/issues/detail?id=94301 it seems that this icon size is also being used even though the documentation doesn't mention it. So please add it here as well.
18 webAccessible = block.html icons/abp-128.png	18 webAccessible = block.html icons/abp-128.png

19	19

20 [compat]	20 [compat]

21 chrome = 18.0	21 chrome = 18.0

22	22

23 [convert_js]	23 [convert_js]

24 lib/io.js = lib/filesystem/io.js	24 lib/io.js = lib/filesystem/io.js

25 --arg module=true	25 --arg module=true

26	26

27 [mapping]	27 [mapping]

28 icons/abp-16.png = chrome/icons/abp-16.png

29 icons/abp-19.png = chrome/icons/abp-19.png	28 icons/abp-19.png = chrome/icons/abp-19.png

30 icons/abp-19-notification-critical.png = chrome/icons/abp-19-notification-critic al.png	29 icons/abp-19-notification-critical.png = chrome/icons/abp-19-notification-critic al.png

31 icons/abp-19-notification-information.png = chrome/icons/abp-19-notification-inf ormation.png	30 icons/abp-19-notification-information.png = chrome/icons/abp-19-notification-inf ormation.png

32 icons/abp-48.png = chrome/icons/abp-48.png	31 icons/abp-48.png = chrome/icons/abp-48.png

33	32

34 [convert_img]	33 [convert_img]

35 icons/abp-19-notification-critical-1.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.1)	34 icons/abp-19-notification-critical-1.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.1)

36 icons/abp-19-notification-critical-2.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.2)	35 icons/abp-19-notification-critical-2.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.2)

37 icons/abp-19-notification-critical-3.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.3)	36 icons/abp-19-notification-critical-3.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.3)

38 icons/abp-19-notification-critical-4.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.4)	37 icons/abp-19-notification-critical-4.png = chrome/icons/abp-19.png -> blend(chro me/icons/abp-19-notification-critical.png, 0.4)

(...skipping 23 matching lines...) Expand all Loading...
62 icons/abp-19-whitelisted-notification-critical-9.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.9)	61 icons/abp-19-whitelisted-notification-critical-9.png = chrome/icons/abp-19.png - > blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notificati on-critical.png, 0.9)

63 icons/abp-19-whitelisted-notification-information-1.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.1)	62 icons/abp-19-whitelisted-notification-information-1.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.1)

64 icons/abp-19-whitelisted-notification-information-2.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.2)	63 icons/abp-19-whitelisted-notification-information-2.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.2)

65 icons/abp-19-whitelisted-notification-information-3.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.3)	64 icons/abp-19-whitelisted-notification-information-3.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.3)

66 icons/abp-19-whitelisted-notification-information-4.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.4)	65 icons/abp-19-whitelisted-notification-information-4.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.4)

67 icons/abp-19-whitelisted-notification-information-5.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.5)	66 icons/abp-19-whitelisted-notification-information-5.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.5)

68 icons/abp-19-whitelisted-notification-information-6.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.6)	67 icons/abp-19-whitelisted-notification-information-6.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.6)

69 icons/abp-19-whitelisted-notification-information-7.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.7)	68 icons/abp-19-whitelisted-notification-information-7.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.7)

70 icons/abp-19-whitelisted-notification-information-8.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.8)	69 icons/abp-19-whitelisted-notification-information-8.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.8)

71 icons/abp-19-whitelisted-notification-information-9.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.9)	70 icons/abp-19-whitelisted-notification-information-9.png = chrome/icons/abp-19.pn g -> blend(255, 255, 255, 0.2) -> grayscale -> blend(chrome/icons/abp-19-notific ation-information.png, 0.9)

LEFT	RIGHT