Issue 1091 - Implement a better templating approach for Element Hiding Helper

Issue 1091 - Implement a better templating approach for Element Hiding Helper

[Thomas Greiner, 2014-07-23 13:55:52]

http://codereview.adblockplus.org/5684127030312960/diff/5629499534213120/lib/...
File lib/aardvark.js (right):

http://codereview.adblockplus.org/5684127030312960/diff/5629499534213120/lib/...
lib/aardvark.js:41: };
What's the reason for introducing a custom type here instead of using DOM
objects? IMHO avoiding it makes the element creation simpler regarding both
definition and use.

e.g.

function createElement(doc, tagName, attr, children)
{
  let el = doc.createElement(tagName);
  if (attr)
    for (let i in attr)
      el.setAttribute(i, attr[i]);
  if (children)
    for (let child of children)
      el.appendChild(child);
  return el;
}

...

let create = createElement.bind(null, doc);
this.boxElem = create("div", {"class": elementMarkerClass}, [
  create("div", {"class": "ehh-border"}),
  create("div", {"class": "ehh-label"}, [
    create("span", {"class": "ehh-labelTag"}),
    create("span", {"class": "ehh-labelAddition"})
  ])
]);

[Wladimir Palant, 2014-09-11 16:52:12]

http://codereview.adblockplus.org/5684127030312960/diff/5629499534213120/lib/...
File lib/aardvark.js (right):

http://codereview.adblockplus.org/5684127030312960/diff/5629499534213120/lib/...
lib/aardvark.js:41: };
This code went through several iteration, particularly because I considered too
many function parameters not obvious enough. However, since I decided to have
attributes as parameters not doing the same for child elements doesn't make any
sense.

[Thomas Greiner, 2014-09-15 09:47:11]

LGTM