Issue 2184 - Configure codereview setup to use PostgreSQL

modules/rietveld/manifests/init.pp

 class rietveld(
     $domain,
     $certificate,
     $private_key,
     $is_default = false,
     $secret_key = hiera('rietveld::secret_key', ''),
     $fixtures = hiera('rietveld::fixtures', {}),
+    $database = hiera('rietveld::database', {

[Felix Dahlke, 2015/04/22 05:32:23]

Shouldn't we just set engine and name as below in the hiera configuration for
that node and fail if it's not specified?

[mathias, 2015/04/23 16:28:49]

The idea is to have a working development setup without additional configuration
(which is possible anywhere with Hiera, in theory at least) - just including the
class should be enough (the $domain, $certificate, etc parameters are meant to
vanish from this file in another patch-set, as mentioned earlier). One could of
course argue that failing early when someone did not remember to configure every
requirement is more important than an out-of-the-box working solution. This
boils down to personal preference or philosophy, I guess. For myself, I prefer
the out-of-the-box approach (though I can live with either one). What about you?

[Felix Dahlke, 2015/05/11 20:10:45]

So you mean you'd want to move away from private-stub in the long run and use
defaults instead?

+      'engine' => 'sqlite3',
+      'name' => 'dev.db',
+    }),
 ) {
 
   include nginx
   $django_home = '/home/rietveld/django-gae2django'
   $rietveld_home = "${django_home}/examples/rietveld"
 
   Exec {
     path => '/usr/bin:/usr/sbin:/bin:/usr/local/bin',
   }
 
@@ skipping 35 matching lines @@
     content => template('rietveld/settings.py.erb'),
   }
 
   exec {'install_rietveld':
     command => "make all",
     cwd => "${rietveld_home}",
     user => rietveld,
     require => [
       File["${rietveld_home}/Makefile"],
       File["${rietveld_home}/settings.py"]],
-    onlyif => "test ! -f ${$rietveld_home}/dev.db",
+    onlyif => "test ! -e ${$rietveld_home}/gae2django",
   }
 
   file {'/etc/init/rietveld.conf':
     ensure => file,
     owner => root,
     source => 'puppet:///modules/rietveld/rietveld.conf',
     notify => Service['rietveld'],
   }
 
   file {'/etc/init.d/rietveld':
@@ skipping 42 matching lines @@
       mode => 0640,
       notify => $ensure ? {
         present => Exec[$destination],
         default => [],
       }
     }
   }
 
   create_resources(rietveld::fixture, $fixtures)
 }