Issue 2184 - Configure codereview setup to use PostgreSQL

modules/rietveld/manifests/init.pp

Index: modules/rietveld/manifests/init.pp
diff --git a/modules/rietveld/manifests/init.pp b/modules/rietveld/manifests/init.pp
index 59e3a353276fadc167b58a5bc0d85e34a7b1ef2b..2149e1fef5b23319595c206e78945d910d47f0e1 100644
--- a/modules/rietveld/manifests/init.pp
+++ b/modules/rietveld/manifests/init.pp
@@ -5,6 +5,10 @@ class rietveld(
     $is_default = false,
     $secret_key = hiera('rietveld::secret_key', ''),
     $fixtures = hiera('rietveld::fixtures', {}),
+    $database = hiera('rietveld::database', {

[Felix Dahlke, 2015/04/22 05:32:23]

Shouldn't we just set engine and name as below in the hiera configuration for
that node and fail if it's not specified?

[mathias, 2015/04/23 16:28:49]

The idea is to have a working development setup without additional configuration
(which is possible anywhere with Hiera, in theory at least) - just including the
class should be enough (the $domain, $certificate, etc parameters are meant to
vanish from this file in another patch-set, as mentioned earlier). One could of
course argue that failing early when someone did not remember to configure every
requirement is more important than an out-of-the-box working solution. This
boils down to personal preference or philosophy, I guess. For myself, I prefer
the out-of-the-box approach (though I can live with either one). What about you?

[Felix Dahlke, 2015/05/11 20:10:45]

So you mean you'd want to move away from private-stub in the long run and use
defaults instead?

+      'engine' => 'sqlite3',
+      'name' => 'dev.db',
+    }),
 ) {
 
   include nginx
@@ -60,7 +64,7 @@ class rietveld(
     require => [
       File["${rietveld_home}/Makefile"],
       File["${rietveld_home}/settings.py"]],
-    onlyif => "test ! -f ${$rietveld_home}/dev.db",
+    onlyif => "test ! -e ${$rietveld_home}/gae2django",
   }
 
   file {'/etc/init/rietveld.conf':