Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/JsValue.h

Issue 5691839784943616: Change the way persistent handles are desctructed. Add tests. (Closed)
Patch Set: Created July 10, 2014, 11:44 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/V8ValueHolder.h » ('j') | include/AdblockPlus/V8ValueHolder.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #ifndef ADBLOCK_PLUS_JS_VALUE_H 18 #ifndef ADBLOCK_PLUS_JS_VALUE_H
19 #define ADBLOCK_PLUS_JS_VALUE_H 19 #define ADBLOCK_PLUS_JS_VALUE_H
20 20
21 #include <stdint.h> 21 #include <stdint.h>
22 #include <string> 22 #include <string>
23 #include <vector> 23 #include <vector>
24 #include "tr1_memory.h" 24 #include "tr1_memory.h"
25 #include "V8ValueHolder.h" 25 #include "V8ValueHolder.h"
26 26
27 namespace v8 27 namespace v8
28 { 28 {
29 class Value;
30 template<class T> class Handle; 29 template<class T> class Handle;
31 } 30 }
32 31
33 namespace AdblockPlus 32 namespace AdblockPlus
34 { 33 {
35 class JsValue; 34 class JsValue;
36 class JsEngine; 35 class JsEngine;
37 36
38 typedef std::tr1::shared_ptr<JsValue> JsValuePtr; 37 typedef std::tr1::shared_ptr<JsValue> JsValuePtr;
39 typedef std::vector<AdblockPlus::JsValuePtr> JsValueList; 38 typedef std::vector<AdblockPlus::JsValuePtr> JsValueList;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 protected: 79 protected:
81 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value); 80 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
82 void SetProperty(const std::string& name, v8::Handle<v8::Value> val); 81 void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
83 82
84 JsEnginePtr jsEngine; 83 JsEnginePtr jsEngine;
85 V8ValueHolder<v8::Value> value; 84 V8ValueHolder<v8::Value> value;
86 }; 85 };
87 } 86 }
88 87
89 #endif 88 #endif
OLDNEW
« no previous file with comments | « no previous file | include/AdblockPlus/V8ValueHolder.h » ('j') | include/AdblockPlus/V8ValueHolder.h » ('J')

Powered by Google App Engine
This is Rietveld