Change the way persistent handles are desctructed. Add tests.

test/JsValue.cpp

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "BaseJsTest.h"
-
+#include "v8-profiler.h"
 namespace
 {
   class JsValueTest : public BaseJsTest
   {
   };
 }
 
+
 TEST_F(JsValueTest, UndefinedValue)
 {
   AdblockPlus::JsValuePtr value = jsEngine->Evaluate("undefined");
   ASSERT_TRUE(value->IsUndefined());
   ASSERT_FALSE(value->IsNull());
   ASSERT_FALSE(value->IsString());
   ASSERT_FALSE(value->IsBool());
   ASSERT_FALSE(value->IsNumber());
   ASSERT_FALSE(value->IsObject());
   ASSERT_FALSE(value->IsArray());
@@ skipping 173 matching lines @@
   const std::string source("\
     function Foo() {\
       this.toString = function() {throw 'test1';};\
       this.valueOf = function() {throw 'test2';};\
     };\
     new Foo()");
   AdblockPlus::JsValuePtr value = jsEngine->Evaluate(source);
   ASSERT_EQ("", value->AsString());
   ASSERT_EQ(0, value->AsInt());
 }
+
+TEST_F(JsValueTest, PersistentWeakHandleDisposalComplex)
+{
+  // Force GC
+  v8::V8::AdjustAmountOfExternalAllocatedMemory(1000000000);
+  while (!v8::V8::IdleNotification()) {};
+  _sleep(500);
+
+  v8::HeapProfiler heapProfiler;
+  int numberOfHandlesBefore = 0;
+
+  // Create and destroy persistent handle for an object
+  {
+    numberOfHandlesBefore = heapProfiler.GetPersistentHandleCount();
+    AdblockPlus::JsValuePtr value = jsEngine->NewObject();
+  }
+
+  // Force GC
+  v8::V8::AdjustAmountOfExternalAllocatedMemory(1000000000);
+  while (!v8::V8::IdleNotification()) {};
+  _sleep(500);
+
+  ASSERT_EQ(numberOfHandlesBefore, heapProfiler.GetPersistentHandleCount());
+}
+
+TEST_F(JsValueTest, PersistentWeakHandleDisposalPrimitive)
+{
+  // Force GC
+  v8::V8::AdjustAmountOfExternalAllocatedMemory(1000000000);
+  while (!v8::V8::IdleNotification()) {};
+  _sleep(500);
+
+  v8::HeapProfiler heapProfiler;
+  int numberOfHandlesBefore = 0;
+
+  // Create and destroy persistent handle for a primitive
+  {
+    numberOfHandlesBefore = heapProfiler.GetPersistentHandleCount();  
+    AdblockPlus::JsValuePtr value = jsEngine->NewValue(false);
+    AdblockPlus::JsValuePtr value2 = jsEngine->NewValue(0);
+  }
+
+  // Force GC
+  v8::V8::AdjustAmountOfExternalAllocatedMemory(1000000000);
+  while (!v8::V8::IdleNotification()) {};
+  _sleep(500);
+
+  ASSERT_EQ(numberOfHandlesBefore, heapProfiler.GetPersistentHandleCount());
+}