Issue 2040 - Replaced localStorage with chrome.storage.local

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 459 matching lines @@
   });
 
   // We have to ensure there is at least one listener for the onConnect event.
   // Otherwise we can't connect a port later, which we need to do in order to
   // detect when the extension is reloaded, disabled or uninstalled.
   chrome.runtime.onConnect.addListener(function() {});
 
 
   /* Storage */
 
-  ext.storage = localStorage;
+  ext.storage = {
+    get: function(keys, callback)
+    {
+      chrome.storage.local.get(keys, callback);
+    },
+    set: function(key, value, callback)
+    {
+      let items = {};
+      items[key] = value;
+      chrome.storage.local.set(items, callback);
+    },
+    remove: function(key, callback)
+    {
+      chrome.storage.local.remove(key, callback);
+    },
+    onChanged: chrome.storage.onChanged,
 
+    // Migrate localStorage to chrome.storage.local,
+    // ignoring unkown and inavlid preferences.
+    migratePrefs: function(prefs)
+    {
+      var items = {};
+
+      for (let key in localStorage)
+      {
+        var value = localStorage[key];
+
+        if (key in prefs)
+        {
+          try
+          {
+            items["pref:" + key] = JSON.parse(value);

[kzar, 2015/03/09 15:10:29]

Nit: Shouldn't this make use of the const keyPrefix?

[Sebastian Noack, 2015/03/09 15:21:37]

It's not available here, and IMO not worth beeing exported just for the
temporary migration code.

[kzar, 2015/03/09 15:24:28]

Fair enough, yea I agree it doesn't really matter.

+          }
+          catch (e)
+          {
+          }
+        }
+        else if (key == "currentVersion")
+        {
+          items[key] = value;
+        }
+      }
+
+      chrome.storage.local.set(items, function() {
+        localStorage.clear();
+      });
+    }
+  };
 
   /* Options */
 
   ext.showOptions = function(callback)
   {
     chrome.windows.getLastFocused(function(win)
     {
       var optionsUrl = chrome.extension.getURL("options.html");
       var queryInfo = {url: optionsUrl};
 
@@ skipping 22 matching lines @@
             callback(new Page(tab));
         }
         else
         {
           ext.pages.open(optionsUrl, callback);
         }
       });
     });
   };
 })();