Issue 2040 - Replaced localStorage with chrome.storage.local

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 40 matching lines @@
 var ElemHide = require("elemHide").ElemHide;
 var defaultMatcher = require("matcher").defaultMatcher;
 var Prefs = require("prefs").Prefs;
 var Synchronizer = require("synchronizer").Synchronizer;
 var Utils = require("utils").Utils;
 var NotificationStorage = require("notification").Notification;
 var initAntiAdblockNotification = require("antiadblockInit").initAntiAdblockNotification;
 var parseFilters = require("filterValidation").parseFilters;
 var composeFilters = require("filterComposer").composeFilters;
 
+// Chrome on Linux does not fully support chrome.notifications until version 35
+// https://code.google.com/p/chromium/issues/detail?id=291485
+var canUseChromeNotifications = (function()
+{
+  var info = require("info");
+  if (info.platform == "chromium" && "notifications" in chrome)
+  {
+    if (navigator.platform.indexOf("Linux") == -1)
+      return true;
+    if (Services.vc.compare(info.applicationVersion, "35") >= 0)
+      return true;
+  }
+  return false;
+})();
+
 var seenDataCorruption = false;
 var filterlistsReinitialized = false;
 
 function init()
 {
   var filtersLoaded = false;
   var prefsLoaded = false;
 
-  var onProgress = function()
+  var checkLoaded = function()
   {
     if (!filtersLoaded || !prefsLoaded)
       return;
 
     var info = require("info");
     var previousVersion = Prefs.currentVersion;
 
     // There are no filters stored so we need to reinitialize all filterlists
     if (!FilterStorage.firstRun && FilterStorage.subscriptions.length === 0)
     {
       filterlistsReinitialized = true;
       previousVersion = null;
     }
 
     if (previousVersion != info.addonVersion || FilterStorage.firstRun)
     {
       seenDataCorruption = previousVersion && FilterStorage.firstRun;
       Prefs.currentVersion = info.addonVersion;
       addSubscription(previousVersion);
     }
 
     // The "Hide placeholders" option has been removed from the UI in 1.8.8.1285
     // So we reset the option for users updating from older versions.
     if (previousVersion && Services.vc.compare(previousVersion, "1.8.8.1285") < 0)
       Prefs.hidePlaceholders = true;
 
-    // Chrome on Linux does not fully support chrome.notifications until version 35
-    // https://code.google.com/p/chromium/issues/detail?id=291485
-    if (info.platform == "chromium" && "notifications" in chrome &&
-        (navigator.platform.indexOf("Linux") == -1 ||
-         Services.vc.compare(info.applicationVersion, "35") >= 0))
+    if (canUseChromeNotifications)
       initChromeNotifications();
     initAntiAdblockNotification();
 
     // Update browser actions and context menus when whitelisting might have
     // changed. That is now when initally loading the filters and later when
     // importing backups or saving filter changes.
     FilterNotifier.addListener(function(action)
     {
       if (action == "load" || action == "save")
         refreshIconAndContextMenuForAllPages();
     });
     refreshIconAndContextMenuForAllPages();
   };
 
   var onFilterAction = function(action)
   {
     if (action == "load")
     {
       FilterNotifier.removeListener(onFilterAction);
       filtersLoaded = true;
-      onProgress();
+      checkLoaded();
     }
   };
 
   var onPrefsLoaded = function()
   {
     Prefs.onLoaded.removeListener(onPrefsLoaded);
     prefsLoaded = true;
-    onProgress();
+    checkLoaded();
   };
 
   FilterNotifier.addListener(onFilterAction);
   Prefs.onLoaded.addListener(onPrefsLoaded);
 }
 init();
 
 // Special-case domains for which we cannot use style-based hiding rules.
 // See http://crbug.com/68705.
 var noStyleRulesHosts = ["mail.google.com", "mail.yahoo.com", "www.google.com"];
@@ skipping 465 matching lines @@
   page.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(page);
 });
 
 setTimeout(function()
 {
   var notificationToShow = NotificationStorage.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);