Usage of new API, cleanups (reduced)

src/org/adblockplus/libadblockplus/Filter.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus;
 
-public class Filter extends JsValue
+public final class Filter extends JsValue

[Felix Dahlke, 2014/04/28 07:29:01]

Are you making all classes final as well while final-ing everything? I don't
mind, just curious why: Is there any benefit beyond ensuring it cannot be
subclassed?

[René Jeschke, 2014/04/28 08:34:32]

Filter and Subscription are both not intended to be sub-classed, so I tend to
forbid this.

[Felix Dahlke, 2014/04/28 10:09:41]

Ah. Thought there may be some tangiable benefits maybe, in C++ e.g. it's a huge
win if you don't need a vtable, but that's not how the JVM works of course.

[René Jeschke, 2014/04/28 10:18:34]

Done.

 {
   static
   {
     System.loadLibrary("adblockplus-jni");
     registerNatives();
   }
 
   public Filter(final JsValue jsValue)
   {
     super(ctor(jsValue.ptr));
@@ skipping 53 matching lines @@
   private final static native Type getType(long ptr);
 
   private final static native boolean isListed(long ptr);
 
   private final static native void addToList(long ptr);
 
   private final static native void removeFromList(long ptr);
 
   private final static native boolean operatorEquals(long ptr, long other);
 }