jni/JniJsValue.h - Issue 5697499218051072: Usage of new API, cleanups (reduced)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: jni/JniJsValue.h

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)

Patch Set: Even more review issues fixed. Created April 28, 2014, 10:18 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: jni/JniJsValue.h

diff --git a/jni/JniJsValue.h b/jni/JniJsValue.h

index 43fc200eba7b3a4d89c7f9e5698db39a83ad023f..57248835371f2144cb377739774a168f39167e09 100644

--- a/jni/JniJsValue.h

+++ b/jni/JniJsValue.h

@@ -21,7 +21,7 @@

#include <jni.h>

#include <AdblockPlus/JsValue.h>

-jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValuePtr& jsValue);

+jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValuePtr& jsValue, jclass jsValueClass = 0);

jobject JniJsValueListToArrayList(JNIEnv* env, AdblockPlus::JsValueList& list);

« no previous file with comments | « jni/JniFilterChangeCallback.cpp ('k') | jni/JniJsValue.cpp » ('j') | no next file with comments »