Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(314)

Issue 5698232457887744: Issue 1644 - Recognize <input type=image> elements with the correct type on Safari (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by Sebastian Noack
Modified:
5 years ago
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1644 - Recognize <input type=image> elements with the correct type on Safari

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M safari/ext/content.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
5 years ago (2014-12-02 13:07:54 UTC) #1
kzar
After you explained in IRC it LGTM. Nitpick: beforeLoad event isn't well documented online so ...
5 years ago (2014-12-03 09:58:56 UTC) #2
Sebastian Noack
The beforeload event is documented here: https://developer.apple.com/library/safari/documentation/tools/conceptual/safariextensionguide/MessagesandProxies/MessagesandProxies.html However, the code changed here just maps tag ...
5 years ago (2014-12-03 10:13:43 UTC) #3
kzar
I saw that page but I couldn't see anything to say exactly when the event ...
5 years ago (2014-12-03 10:16:12 UTC) #4
Sebastian Noack
Background images are neither considered for the standard "load" and "error" events. So IMO its ...
5 years ago (2014-12-03 10:31:35 UTC) #5
Wladimir Palant
5 years ago (2014-12-03 13:49:41 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5