Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5703008528629760: Issue 2071 - Fixed issues when sending messages from the popup to the background page (Closed)

Created:
March 2, 2015, 11:57 a.m. by Sebastian Noack
Modified:
March 3, 2015, 8:25 a.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 2071 - Fixed issues when sending messages from the popup to the background page

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -21 lines) Patch
M chrome/ext/background.js View 1 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/ext/popup.js View 1 chunk +20 lines, -5 lines 0 comments Download
M safari/ext/background.js View 1 chunk +0 lines, -10 lines 0 comments Download
M safari/ext/popup.js View 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 5
Sebastian Noack
March 2, 2015, 11:58 a.m. (2015-03-02 11:58:26 UTC) #1
kzar
http://codereview.adblockplus.org/5703008528629760/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/5703008528629760/diff/5629499534213120/chrome/ext/background.js#newcode438 chrome/ext/background.js:438: // Add "page" and "frame" if messsage were sent ...
March 2, 2015, 7 p.m. (2015-03-02 19:00:32 UTC) #2
kzar
(Sorry I meant to write "is_popup" there obviously.)
March 2, 2015, 7:04 p.m. (2015-03-02 19:04:03 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5703008528629760/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/5703008528629760/diff/5629499534213120/chrome/ext/background.js#newcode438 chrome/ext/background.js:438: // Add "page" and "frame" if messsage were sent ...
March 2, 2015, 7:42 p.m. (2015-03-02 19:42:08 UTC) #4
Wladimir Palant
March 2, 2015, 8:27 p.m. (2015-03-02 20:27:34 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld