Issue 2071 - Fixed issues when sending messages from the popup to the background page

chrome/ext/popup.js

-window.ext = Object.create(chrome.extension.getBackgroundPage().ext);
+(function()
+{
+  var backgroundPage = chrome.extension.getBackgroundPage();
+  window.ext = Object.create(backgroundPage.ext);
 
-ext.closePopup = function()
-{
-  window.close();
-};
+  ext.closePopup = function()
+  {
+    window.close();
+  };
+
+  // We have to override ext.backgroundPage, because in order
+  // to send messages the local "chrome" namespace must be used.
+  ext.backgroundPage = {
+    sendMessage: chrome.runtime.sendMessage,

[kzar, 2015/03/02 19:00:32]

Dumb idea: wrap the sendMessage call here to add a special key to the message.
The background page could then spot that special key ("is_tab" maybe?) and use
it to differentiate between messages sent from the popup page and the background
one.

[Sebastian Noack, 2015/03/02 19:42:08]

Currently, we don't need that information. So adding it now, would just be
premature optimization.

+
+    getWindow: function()
+    {
+      return backgroundPage;
+    }
+  };
+})();