Issue 2563 - [cms] Cache filters and globals during page generation

cms/sources.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 49 matching lines @@
 
     path = "/%s/%s" % (locale, page)
     return locale, urlparse.urlunparse(parsed[0:2] + (path,) + parsed[3:])
 
   def read_config(self):
     configdata = self.read_file("settings.ini")
     config = ConfigParser.SafeConfigParser()
     config.readfp(StringIO(configdata))
     return config
 
+  def import_symbol(self, filename, symbol):
+    code = self.read_file(filename)
+    namespace = {}

[Sebastian Noack, 2015/05/20 16:01:39]

Note that I refactored this logic while moving it here. I realized that we
actually don't need a module but just a dictionary. The most important
difference is that the globals aren't set to None, when the module was garbage
collected. Hence we don't need to keep an explicit reference around anymore.

+    exec code in namespace
+
+    try:
+      return namespace[symbol]
+    except KeyError:
+      raise Exception("Expected symbol %s not found in %s" % (symbol, filename))
+
   #
   # Page helpers
   #
 
   @staticmethod
   def page_filename(page, format):
     return "pages/%s.%s" % (page, format)
 
   def list_pages(self):
     for filename in self.list_files("pages"):
@@ skipping 197 matching lines @@
         path = os.path.join(dir, filename)
         if os.path.isfile(path):
           result.append(relpath + filename)
         elif os.path.isdir(path):
           do_list(path, relpath + filename + "/")
     do_list(self.get_path(subdir), "")
     return result
 
   def get_cache_dir(self):
     return os.path.join(self._dir, "cache")