Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5705421486555136: First run page and subscription on install fix (FF for android) (Closed)

Created:
April 25, 2014, 11:40 a.m. by saroyanm
Modified:
April 25, 2014, 3:40 p.m.
Reviewers:
Wladimir Palant
CC:
Felix Dahlke
Visibility:
Public.

Description

This fix is related to current ticket: https://issues.adblockplus.org/ticket/99

Patch Set 1 #

Total comments: 3

Patch Set 2 : moved CustomizableUI initialization into UI.initDone() #

Total comments: 2

Patch Set 3 : check if CustomizableUI is set in isToolbarIconVisible() and toggleToolbarIcon() methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M lib/ui.js View 1 2 4 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 6
saroyanm
I've noticed that the UI module in appSupport.js (ln:832) is not being loaded. Actually seams ...
April 25, 2014, 12:08 p.m. (2014-04-25 12:08:06 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5705421486555136/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5705421486555136/diff/5629499534213120/lib/ui.js#newcode279 lib/ui.js:279: } This doesn't resolve the circular reference. The modules ...
April 25, 2014, 12:39 p.m. (2014-04-25 12:39:54 UTC) #2
saroyanm
Wladimir can you please have a look on updated patch. http://codereview.adblockplus.org/5705421486555136/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5705421486555136/diff/5629499534213120/lib/ui.js#newcode279 ...
April 25, 2014, 2:04 p.m. (2014-04-25 14:04:22 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5705421486555136/diff/5086100271923200/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5705421486555136/diff/5086100271923200/lib/ui.js#newcode150 lib/ui.js:150: } Same change would have to be done in ...
April 25, 2014, 2:32 p.m. (2014-04-25 14:32:19 UTC) #4
saroyanm
The patch Updated. http://codereview.adblockplus.org/5705421486555136/diff/5086100271923200/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5705421486555136/diff/5086100271923200/lib/ui.js#newcode150 lib/ui.js:150: } On 2014/04/25 14:32:19, Wladimir Palant ...
April 25, 2014, 3:10 p.m. (2014-04-25 15:10:21 UTC) #5
Wladimir Palant
April 25, 2014, 3:23 p.m. (2014-04-25 15:23:34 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld