Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: build.py

Issue 5710085762318336: 1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository (Closed)
Patch Set: Created Jan. 13, 2015, 5:14 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « .hgsubstate ('k') | dependencies » ('j') | dependencies » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # coding: utf-8 2 # coding: utf-8
3 3
4 import os, sys, subprocess 4 import os, sys, subprocess
5 5
6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py")
7
8 if os.path.isfile(DEPENDENCY_SCRIPT):
Sebastian Noack 2015/01/13 17:21:53 Why do you check whether the script exists? It's t
paco 2015/01/14 11:40:49 As requested by Wladimir, we should call the scrip
Sebastian Noack 2015/01/14 11:58:46 I am not sure whether I agree. The only scenario w
Wladimir Palant 2015/01/14 13:11:17 The idea was actually that this build script is to
paco 2015/01/14 16:00:36 Will remove `if` in next patch
9 try:
10 subprocess.check_call(["python", DEPENDENCY_SCRIPT])
11 except subprocess.CalledProcessError as e:
12 print >>sys.stderr, e
13 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"
14
6 import buildtools.build 15 import buildtools.build
7 buildtools.build.processArgs('.', sys.argv) 16 buildtools.build.processArgs('.', sys.argv)
OLDNEW
« no previous file with comments | « .hgsubstate ('k') | dependencies » ('j') | dependencies » ('J')

Powered by Google App Engine
This is Rietveld