Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: build.py

Issue 5710085762318336: 1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository (Closed)
Patch Set: '1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository' Created Jan. 14, 2015, 4:08 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « .hgsubstate ('k') | dependencies » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # coding: utf-8 2 # coding: utf-8
3 3
4 import os, sys, subprocess 4 import os, sys, subprocess
5 5
6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py")
7
8 try:
9 subprocess.check_call([sys.executable, DEPENDENCY_SCRIPT])
10 except subprocess.CalledProcessError as e:
11 print >>sys.stderr, e
12 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"
13
Sebastian Noack 2015/01/14 16:34:13 Maybe exit with a non-0 status code?
Sebastian Noack 2015/01/14 17:28:36 Thinking again about it, I think it's OK to just s
Wladimir Palant 2015/01/14 17:42:46 Making dependency issues non-fatal was one of the
6 import buildtools.build 14 import buildtools.build
7 buildtools.build.processArgs('.', sys.argv) 15 buildtools.build.processArgs('.', sys.argv)
OLDNEW
« no previous file with comments | « .hgsubstate ('k') | dependencies » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld