build.py - Issue 5710085762318336: 1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: build.py

Issue 5710085762318336: 1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository (Closed)

Patch Set: '1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository' Created Jan. 14, 2015, 4:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # coding: utf-8	2 # coding: utf-8

3	3

4 import os, sys, subprocess	4 import os, sys, subprocess

5	5

	6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py")

	7

	8 try:

	9 subprocess.check_call([sys.executable, DEPENDENCY_SCRIPT])

	10 except subprocess.CalledProcessError as e:

	11 print >>sys.stderr, e

	12 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"

	13
	Sebastian Noack 2015/01/14 16:34:13 Maybe exit with a non-0 status code? Maybe exit with a non-0 status code? Sebastian Noack 2015/01/14 17:28:36 Thinking again about it, I think it's OK to just s Show quoted text On 2015/01/14 16:34:13, Sebastian Noack wrote: > Maybe exit with a non-0 status code? Thinking again about it, I think it's OK to just show a warning continuing with the build when dependencies failed to update. Otherwise you also won't be able to work offline. Wladimir Palant 2015/01/14 17:42:46 Making dependency issues non-fatal was one of the Show quoted text On 2015/01/14 16:34:13, Sebastian Noack wrote: > Maybe exit with a non-0 status code? Making dependency issues non-fatal was one of the reasons we wanted to get rid of Mercurial dependencies...
6 import buildtools.build	14 import buildtools.build

7 buildtools.build.processArgs('.', sys.argv)	15 buildtools.build.processArgs('.', sys.argv)

OLD	NEW

« no previous file with comments | « .hgsubstate ('k') | dependencies » ('j') | no next file with comments »