build.py - Issue 5710085762318336: 1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: build.py

Issue 5710085762318336: 1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository (Closed)

Left Patch Set: '1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository' Created Jan. 14, 2015, 11:40 a.m.

Right Patch Set: '1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository' Created Jan. 15, 2015, 1:40 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # coding: utf-8	2 # coding: utf-8

3	3

4 import os, sys, subprocess	4 import os, sys, subprocess

5	5

6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py")	6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py")

7	7

8 if os.path.isfile(DEPENDENCY_SCRIPT):	8 try:

9 try:	9 subprocess.check_call([sys.executable, DEPENDENCY_SCRIPT])

10 subprocess.check_call(["python", DEPENDENCY_SCRIPT])	10 except subprocess.CalledProcessError as e:
Wladimir Palant 2015/01/14 13:11:17 Only realized now - this shouldn't be "python" but Only realized now - this shouldn't be "python" but rather sys.interpreter. paco 2015/01/14 16:00:36 As discussed on IRC, this should be `sys.executabl Show quoted text On 2015/01/14 13:11:17, Wladimir Palant wrote: > Only realized now - this shouldn't be "python" but rather sys.interpreter. As discussed on IRC, this should be `sys.executable`, will appear on next patch
11 except subprocess.CalledProcessError as e:	11 print >>sys.stderr, e

12 print >>sys.stderr, e	12 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"

13 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"

14	13

15 import buildtools.build	14 import buildtools.build

16 buildtools.build.processArgs('.', sys.argv)	15 buildtools.build.processArgs('.', sys.argv)

LEFT	RIGHT