Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5717434384252928: Issue 2267 - Unify form handling by reusing form_handler() and encode_email_address() (Closed)

Created:
April 2, 2015, 2:24 p.m. by Sebastian Noack
Modified:
Sept. 25, 2017, 5:52 p.m.
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2267 - Unify form handling by reusing form_handler() and encode_email_address()

Patch Set 1 #

Patch Set 2 : Rebased, use encode_email_address(), use send_simple_response() #

Total comments: 2

Patch Set 3 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -49 lines) Patch
M sitescripts/formmail/web/formmail.py View 1 2 1 chunk +15 lines, -30 lines 0 comments Download
M sitescripts/reports/web/updateReport.py View 1 1 chunk +4 lines, -19 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
April 2, 2015, 2:24 p.m. (2015-04-02 14:24:26 UTC) #1
Sebastian Noack
April 27, 2015, 1:47 p.m. (2015-04-27 13:47:02 UTC) #2
kzar
Nice, looks like a good change. Have you tested these sites still work properly with ...
April 28, 2015, 8:38 a.m. (2015-04-28 08:38:03 UTC) #3
Sebastian Noack
On 2015/04/28 08:38:03, kzar wrote: > Have you tested these sites still work properly with ...
April 28, 2015, 8:45 a.m. (2015-04-28 08:45:16 UTC) #4
kzar
Cool OK, once tested LGTM
April 28, 2015, 8:47 a.m. (2015-04-28 08:47:29 UTC) #5
Sebastian Noack
Sept. 21, 2017, 1:59 a.m. (2017-09-21 01:59:14 UTC) #6
Closing without merge, for now. See
https://issues.adblockplus.org/ticket/2267#comment:3.

Powered by Google App Engine
This is Rietveld