Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(149)

Issue 5719985141841920: issue #331 - Remove localStorage to FileSystem migration code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by saroyanm
Modified:
5 years ago
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/331

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M background.js View 3 chunks +1 line, -28 lines 0 comments Download
M lib/filesystem/io.js View 1 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4
saroyanm
Sebastian, can you please have a look when you'll have a free time. Looks to ...
5 years, 1 month ago (2014-08-14 11:34:16 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5719985141841920/diff/5629499534213120/background.js File background.js (left): http://codereview.adblockplus.org/5719985141841920/diff/5629499534213120/background.js#oldcode164 background.js:164: FilterStorage.loadFromDisk(localStorage["patterns.ini"]); There is a hack in lib/filesystem/io.js, function readFromFile() ...
5 years, 1 month ago (2014-08-14 14:16:13 UTC) #2
saroyanm
new patch uploaded. http://codereview.adblockplus.org/5719985141841920/diff/5629499534213120/background.js File background.js (left): http://codereview.adblockplus.org/5719985141841920/diff/5629499534213120/background.js#oldcode164 background.js:164: FilterStorage.loadFromDisk(localStorage["patterns.ini"]); On 2014/08/14 14:16:13, Wladimir Palant ...
5 years, 1 month ago (2014-08-14 16:09:53 UTC) #3
Sebastian Noack
5 years ago (2014-08-25 10:04:31 UTC) #4
LGTM, from my side.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5