Issue 1985 - Replaced __proto__ with Object.create() and Object.getPrototypeOf()

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 //
 // The values are hardcoded for now.
 //
 
-let defaults = {
-  __proto__: null,
-  enabled: true,
-  data_directory: "",
-  patternsbackups: 5,
-  patternsbackupinterval: 24,
-  savestats: false,
-  privateBrowsing: false,
-  subscriptions_fallbackerrors: 5,
-  subscriptions_fallbackurl: "https://adblockplus.org/getSubscription?version=%VERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CHANNELSTATUS%&responseStatus=%RESPONSESTATUS%",
-  subscriptions_autoupdate: true,
-  subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/exceptionrules.txt",
-  subscriptions_antiadblockurl: "https://easylist-downloads.adblockplus.org/antiadblockfilters.txt",
-  documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%",
-  notificationdata: {},
-  notificationurl: "https://notification.adblockplus.org/notification.json",
-  stats_total: {},
-  show_statsinicon: true,
-  show_statsinpopup: true,
-  shouldShowBlockElementMenu: true,
-  hidePlaceholders: true
-};
+let defaults = Object.create(null);
+defaults.enabled = true;
+defaults.data_directory = "";
+defaults.patternsbackups = 5;
+defaults.patternsbackupinterval = 24;
+defaults.savestats = false;
+defaults.privateBrowsing = false;
+defaults.subscriptions_fallbackerrors = 5;
+defaults.subscriptions_fallbackurl = "https://adblockplus.org/getSubscription?version=%VERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CHANNELSTATUS%&responseStatus=%RESPONSESTATUS%";
+defaults.subscriptions_autoupdate = true;
+defaults.subscriptions_exceptionsurl = "https://easylist-downloads.adblockplus.org/exceptionrules.txt";
+defaults.subscriptions_antiadblockurl = "https://easylist-downloads.adblockplus.org/antiadblockfilters.txt";
+defaults.documentation_link = "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%";
+defaults.notificationdata = {};
+defaults.notificationurl = "https://notification.adblockplus.org/notification.json";
+defaults.stats_total = {};
+defaults.show_statsinicon = true;
+defaults.show_statsinpopup = true;
+defaults.shouldShowBlockElementMenu = true;
+defaults.hidePlaceholders = true;
 
 let listeners = [];
 
 function defineProperty(key)
 {
   let value = null;
   Prefs.__defineGetter__(key, function()
   {
     if (value === null)
     {
@@ skipping 45 matching lines @@
   removeListener: function(listener)
   {
     let index = listeners.indexOf(listener);
     if (index >= 0)
       listeners.splice(index, 1);
   },
 };
 
 for (let key in defaults)
   defineProperty(key);