Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(297)

Issue 5728380594946048: Issue 116 - Document the libadblockplus API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by Felix Dahlke
Modified:
5 years, 3 months ago
Visibility:
Public.

Description

Issue 116 - Document the libadblockplus API

Patch Set 1 #

Total comments: 36

Patch Set 2 : Addressed comments #

Patch Set 3 : Document JsValue and FilterEngine #

Total comments: 63

Patch Set 4 : Documented ReferrerMapping #

Patch Set 5 : Documented the remaining relevant files #

Total comments: 16

Patch Set 6 : Address all comments #

Total comments: 6

Patch Set 7 : Addressed remaining comments #

Patch Set 8 : Fix broken sentences #

Patch Set 9 : Remembered that AppInfo is used for more than update checks #

Total comments: 2

Patch Set 10 : Fix the broken sentence properly #

Patch Set 11 : Write libadblockplus in lower case consistently #

Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -4 lines) Patch
M .hgignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A Doxyfile View 1 2 3 4 5 6 7 8 9 10 1 chunk +7 lines, -0 lines 0 comments Download
M Makefile View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M include/AdblockPlus.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +12 lines, -0 lines 0 comments Download
M include/AdblockPlus/AppInfo.h View 1 3 4 5 6 7 8 9 10 1 chunk +33 lines, -0 lines 0 comments Download
M include/AdblockPlus/DefaultFileSystem.h View 1 2 3 4 5 2 chunks +12 lines, -0 lines 0 comments Download
M include/AdblockPlus/DefaultLogSystem.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M include/AdblockPlus/DefaultWebRequest.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M include/AdblockPlus/FileSystem.h View 1 2 3 4 2 chunks +59 lines, -0 lines 0 comments Download
M include/AdblockPlus/FilterEngine.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +237 lines, -0 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 1 2 3 4 5 6 7 8 2 chunks +119 lines, -0 lines 0 comments Download
M include/AdblockPlus/JsValue.h View 1 2 3 4 5 6 3 chunks +50 lines, -2 lines 0 comments Download
M include/AdblockPlus/LogSystem.h View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M include/AdblockPlus/ReferrerMapping.h View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
M include/AdblockPlus/WebRequest.h View 1 2 3 4 5 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Felix Dahlke
This is still WIP, but I'd still like to get some early feedback. I've documented ...
5 years, 3 months ago (2014-08-28 16:29:14 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5728380594946048/diff/5629499534213120/Doxyfile File Doxyfile (right): http://codereview.adblockplus.org/5728380594946048/diff/5629499534213120/Doxyfile#newcode1 Doxyfile:1: # Doxyfile 1.8.6 On 2014/08/28 16:29:14, Felix H. Dahlke ...
5 years, 3 months ago (2014-08-28 17:24:40 UTC) #2
Felix Dahlke
New patch set. I'll add more documentation and update this review once I'm done with ...
5 years, 3 months ago (2014-08-28 22:56:41 UTC) #3
Wladimir Palant
Looks good now.
5 years, 3 months ago (2014-08-29 06:23:49 UTC) #4
Felix Dahlke
Documented JsValue and FilterEngine, more feedback please. Please note that I'm being intentionally brief (leaving ...
5 years, 3 months ago (2014-08-29 13:18:27 UTC) #5
Felix Dahlke
Alright, now everything is documented, so this is not WIP anymore and officially under review ...
5 years, 3 months ago (2014-08-29 16:38:24 UTC) #6
Wladimir Palant
Done reviewing Patch Set 3, this should keep you busy while I review the rest... ...
5 years, 3 months ago (2014-08-29 18:18:50 UTC) #7
Wladimir Palant
Reviewed the newer changes as well now. http://codereview.adblockplus.org/5728380594946048/diff/5718998062727168/include/AdblockPlus/DefaultFileSystem.h File include/AdblockPlus/DefaultFileSystem.h (right): http://codereview.adblockplus.org/5728380594946048/diff/5718998062727168/include/AdblockPlus/DefaultFileSystem.h#newcode33 include/AdblockPlus/DefaultFileSystem.h:33: * system's ...
5 years, 3 months ago (2014-08-29 18:42:27 UTC) #8
Felix Dahlke
Addressed all comments! http://codereview.adblockplus.org/5728380594946048/diff/5738600293466112/include/AdblockPlus.h File include/AdblockPlus.h (right): http://codereview.adblockplus.org/5728380594946048/diff/5738600293466112/include/AdblockPlus.h#newcode20 include/AdblockPlus.h:20: * This is the source code ...
5 years, 3 months ago (2014-09-01 17:00:14 UTC) #9
Wladimir Palant
http://codereview.adblockplus.org/5728380594946048/diff/5738600293466112/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/5728380594946048/diff/5738600293466112/include/AdblockPlus/FilterEngine.h#newcode146 include/AdblockPlus/FilterEngine.h:146: * Checks if this is the first run of ...
5 years, 3 months ago (2014-09-01 17:36:56 UTC) #10
Felix Dahlke
New patch set. http://codereview.adblockplus.org/5728380594946048/diff/5738600293466112/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/5728380594946048/diff/5738600293466112/include/AdblockPlus/FilterEngine.h#newcode207 include/AdblockPlus/FilterEngine.h:207: * @return Matching filter, or `null` ...
5 years, 3 months ago (2014-09-02 05:24:50 UTC) #11
Wladimir Palant
http://codereview.adblockplus.org/5728380594946048/diff/5678807906254848/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/5728380594946048/diff/5678807906254848/include/AdblockPlus/FilterEngine.h#newcode112 include/AdblockPlus/FilterEngine.h:112: * @return `true` if subscriptions are currently being updated. ...
5 years, 3 months ago (2014-09-02 13:11:21 UTC) #12
Felix Dahlke
http://codereview.adblockplus.org/5728380594946048/diff/5678807906254848/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/5728380594946048/diff/5678807906254848/include/AdblockPlus/FilterEngine.h#newcode112 include/AdblockPlus/FilterEngine.h:112: * @return `true` if subscriptions are currently being updated. ...
5 years, 3 months ago (2014-09-02 13:24:05 UTC) #13
Felix Dahlke
One more patch set: I've been writing libadblockplus/Libadblockplus inconsistently, the official name should be lower ...
5 years, 3 months ago (2014-09-02 14:19:33 UTC) #14
Wladimir Palant
5 years, 3 months ago (2014-09-02 14:52:01 UTC) #15
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5