Issue 2419 - Show newly downloaded notifications immediately

lib/notification.js

Index: lib/notification.js
===================================================================
--- a/lib/notification.js
+++ b/lib/notification.js
@@ -30,7 +30,6 @@
 let INITIAL_DELAY = 12 * MILLIS_IN_MINUTE;
 let CHECK_INTERVAL = 1 * MILLIS_IN_HOUR;
 let EXPIRATION_INTERVAL = 1 * MILLIS_IN_DAY;
-let STARTUP_SHOW_DELAY = 3 * MILLIS_IN_MINUTE;
 let TYPE = {
   information: 0,
   question: 1,
@@ -87,12 +86,6 @@
     downloader.onDownloadSuccess = this._onDownloadSuccess.bind(this);
     downloader.onDownloadError = this._onDownloadError.bind(this);
     onShutdown.add(() => downloader.cancel());
-
-    notificationTimer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);

[Felix Dahlke, 2015/06/08 20:06:23]

While we had IIRC discussed that it makes sense to show notifications _both_
three minutes after startup and when new ones are downloaded, with a reduced
INITIAL_DELAY (we agreed on one minute), IMO it doesn't. We would show emergency
notifications both one and three minutes after startup. If we would only show
them after download, we would show them at most once a day, no matter how often
the user restarts the browser. Seems preferable to showing them twice in short
succession.

I suppose the main downside of this is that users won't see emergency
notifications if our notification infrastructure is not reachable anymore. Seems
fine to me however - if they can't reach that for some reason, it's unlikely
they can do whatever we ask them to do in the notification.

-    notificationTimer.initWithCallback(Notification.showNext.bind(this),
-                                       STARTUP_SHOW_DELAY,
-                                       Ci.nsITimer.TYPE_ONE_SHOT);
-    onShutdown.add(() => notificationTimer.cancel());
   },
 
   /**
@@ -152,6 +145,8 @@
     [Prefs.notificationdata.softExpiration, Prefs.notificationdata.hardExpiration] = downloader.processExpirationInterval(EXPIRATION_INTERVAL);
     Prefs.notificationdata.downloadCount = downloadable.downloadCount;
     saveNotificationData();
+
+    Notification.showNext();
   },
 
   _onDownloadError: function(downloadable, downloadURL, error, channelStatus, responseStatus, redirectCallback)