lib/prefs.js - Issue 5732725684174848: Use safari.extension.settings instead of localStorage and WebSQL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/prefs.js

Issue 5732725684174848: Use safari.extension.settings instead of localStorage and WebSQL (Closed)

Patch Set: Created March 12, 2014, 2:11 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/prefs.js

===================================================================

--- a/lib/prefs.js

+++ b/lib/prefs.js

@@ -50,11 +50,11 @@

{

if (value === null)

{

- if (key in localStorage)

+ if (key in ext.storage)

{

try

{

- value = JSON.parse(localStorage[key]);

+ value = JSON.parse(ext.storage[key]);

}

catch(e)

{

@@ -74,9 +74,9 @@

let stringified = JSON.stringify(newValue);

if (stringified != JSON.stringify(defaults[key]))

- localStorage[key] = stringified;

+ ext.storage[key] = stringified;

else

- delete localStorage[key];

+ delete ext.storage[key];

value = newValue;

« no previous file with comments | « lib/filesystem/io.js ('k') | lib/storage/io.js » ('j') | no next file with comments »