Issue 2368 - Update adblockplus dependency to revision feb391127fe4

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 202 matching lines @@
  * Initializes the notification system.
  */
 exports.initNotifications = function()
 {
   if (canUseChromeNotifications)
     initChromeNotifications();
   initAntiAdblockNotification();
 };
 
 /**
- * Shows the next notification from the queue if any.
- *
- * @param {URL} [url] URL to match notifications to (optional)
- */
-exports.showNextNotification = function(url)
-{
-  NotificationStorage.showNext(url && stringifyURL(url));

[Sebastian Noack, 2015/06/12 09:42:06]

Oh wait, I were too quick. The case where url isn't given here doesn't exist
anymore. So maybe making the argument rudimentary renaming the function to
showNextNotificationForURL?

[Sebastian Noack, 2015/06/12 09:42:42]

s/rudimentary/mandatory/

[Felix Dahlke, 2015/06/12 17:01:35]

Somehow presumed it can be null. But judging from the code, it's always created
using new URL, so I've made it mandatory.

+ * Shows the next notification (if any) for the supplied URL.
+ *
+ * @param {URL} url URL to match notifications to
+ */
+exports.showNextNotificationForUrl = function(url)
+{
+  NotificationStorage.showNext(stringifyURL(url));
 }
 
 /**
  * Gets the active notification to be shown if any.
  *
  * @return {?object}
  */
 exports.getActiveNotification = function()
 {
   return activeNotification;
 };
 
 NotificationStorage.addShowListener(function(notification)
 {
   showNotification(notification);
 });