webrequest.js - Issue 5733084272001024: Issue 2368 - Update adblockplus dependency to revision feb391127fe4

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: webrequest.js

Issue 5733084272001024: Issue 2368 - Update adblockplus dependency to revision feb391127fe4 (Closed)

Patch Set: Hint that there may not be a notification for the supplied URL Created June 12, 2015, 6:23 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: webrequest.js

===================================================================

--- a/webrequest.js

+++ b/webrequest.js

@@ -18,7 +18,7 @@

var FilterNotifier = require("filterNotifier").FilterNotifier;

var RegExpFilter = require("filterClasses").RegExpFilter;

var platform = require("info").platform;

-var showNextNotification = require("notificationHelper").showNextNotification;

+var showNextNotificationForUrl = require("notificationHelper").showNextNotificationForUrl;

ext.webRequest.indistinguishableTypes.forEach(function(types)

{

@@ -52,7 +52,7 @@

// We can't listen to onHeadersReceived in Safari so we need to

// check for notifications here

if (platform != "chromium" && type == "SUBDOCUMENT")

- showNextNotification(url);

+ showNextNotificationForUrl(url);

if (filter)

FilterNotifier.triggerListeners("filter.hitCount", filter, 0, 0, page);

@@ -96,7 +96,7 @@

processKey(header.value, page, frame);

}

- showNextNotification(new URL(details.url));

+ showNextNotificationForUrl(new URL(details.url));

}

chrome.webRequest.onHeadersReceived.addListener(

« no previous file with comments | « lib/notificationHelper.js ('k') | no next file » | no next file with comments »