Issue #1234 - Remove local CString variable from TraverseDocument()

src/plugin/PluginDomTraverserBase.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 259 matching lines @@
 
       if (SUCCEEDED(pFrameCollection->item(vIndex, vRetIndex, &pFrameDispatch)) && pFrameDispatch)
       {
         CComQIPtr<IHTMLElement> pFrameEl = pFrameDispatch;
         if (pFrameEl)
         {
           CComVariant vAttr;
 
           if (SUCCEEDED(pFrameEl->getAttribute(ATL::CComBSTR(L"src"), 0, &vAttr)) && vAttr.vt == VT_BSTR && ::SysStringLen(vAttr.bstrVal) > 0)
           {
-            CString srcLegacy = vAttr.bstrVal;
+            std::wstring src(vAttr.bstrVal, SysStringLen(vAttr.bstrVal));
 
             // Some times, domain is missing. Should this be added on image src's as well?''
-
             // eg. gadgetzone.com.au
-            if (srcLegacy.Left(2) == L"//")
+            if (BeginsWith(src, L"//"))
             {
-              srcLegacy = L"http:" + srcLegacy;
+              src = L"http:" + src;
             }
             // eg. http://w3schools.com/html/html_examples.asp
-            else if (srcLegacy.Left(4) != L"http" && srcLegacy.Left(6) != L"res://")
+            else if (!(BeginsWith(src, L"http") || BeginsWith(src, L"res://")))
             {
-              srcLegacy = L"http://" + ToCString(m_domain) + srcLegacy;
+              src = L"http://" + m_domain + src;
             }
-            std::wstring src(ToWstring(srcLegacy));
             UnescapeUrl(src);
 
             // Check if Iframe should be traversed
             if (OnIFrame(pFrameEl, src, indent))
             {
               CComQIPtr<IWebBrowser2> pFrameBrowser = pFrameDispatch;
               if (pFrameBrowser)
               {
                 TraverseDocument(pFrameBrowser, false, indent);
               }
@@ skipping 156 matching lines @@
   {
     m_cacheIndexLast = 0;
     m_cacheDocumentHasFrames.clear();
     m_cacheDocumentHasIframes.clear();
   }
   m_criticalSection.Unlock();
 }
 
 
 #endif // _PLUGIN_DOM_TRAVERSER_BASE_H_