Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/plugin/PluginUtil.h

Issue 5733210436665344: Issue #1234 - Remove local CString variable from TraverseDocument() (Closed)
Patch Set: Created Oct. 9, 2015, 3:48 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/plugin/PluginDomTraverserBase.h ('k') | test/plugin/UtilTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #pragma once 18 #pragma once
19 #include <string> 19 #include <string>
20 #include <ExDisp.h>
20 21
21 std::wstring HtmlFolderPath(); 22 std::wstring HtmlFolderPath();
22 std::wstring UserSettingsFileUrl(); 23 std::wstring UserSettingsFileUrl();
23 std::wstring FirstRunPageFileUrl(); 24 std::wstring FirstRunPageFileUrl();
24 std::wstring FileUrl(const std::wstring& url); 25 std::wstring FileUrl(const std::wstring& url);
25 std::wstring GetLocationUrl(IWebBrowser2& browser); 26 std::wstring GetLocationUrl(IWebBrowser2& browser);
26 27
28 template<class CharT, class Traits, class Alloc, size_t N>
29 bool BeginsWith(const std::basic_string<CharT, Traits, Alloc>& s, const CharT(&b eginning)[N])
30 {
31 return 0 == s.compare(0, N - 1, beginning);
Oleksandr 2015/10/16 08:03:03 Nit: We try not to use yoda conditions.
32 }
33
27 /** 34 /**
28 * Wrapper around Microsoft API 'UrlUnescape' 35 * Wrapper around Microsoft API 'UrlUnescape'
29 * 36 *
30 * This function has modify-in-place semantics. 37 * This function has modify-in-place behavior, which matches that of its legacy version.
31 * This behavior matches that of the legacy version of this function declared ab ove.
32 * At present, callers of this function have no code to handle error conditions that might arise here. 38 * At present, callers of this function have no code to handle error conditions that might arise here.
33 * Because there's no error handling, therefore, this masks failures in UrlUnesc ape. 39 * Because there's no error handling, therefore, this masks failures in UrlUnesc ape.
34 */ 40 */
35 void UnescapeUrl(std::wstring& url); 41 void UnescapeUrl(std::wstring& url);
36 42
OLDNEW
« no previous file with comments | « src/plugin/PluginDomTraverserBase.h ('k') | test/plugin/UtilTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld