Issue #1234 - Remove local CString variable from TraverseDocument()

src/plugin/PluginUtil.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #pragma once
 #include <string>
 #include <ExDisp.h>
 
 std::wstring HtmlFolderPath();
 std::wstring UserSettingsFileUrl();
 std::wstring FirstRunPageFileUrl();
 std::wstring FileUrl(const std::wstring& url);
 std::wstring GetLocationUrl(IWebBrowser2& browser);
 
 template<class CharT, class Traits, class Alloc, size_t N>
-bool BeginsWith(const std::basic_string<CharT, Traits, Alloc> s, const CharT(&beginning)[N])

[sergei, 2015/10/01 16:23:42]

reference (&) is missed.

+bool BeginsWith(const std::basic_string<CharT, Traits, Alloc>& s, const CharT(&beginning)[N])
 {
   return 0 == s.compare(0, N - 1, beginning);

[Oleksandr, 2015/10/16 08:03:03]

Nit: We try not to use yoda conditions.

 }
+
+/**
+ * Wrapper around Microsoft API 'UrlUnescape'
+ *
+ * This function has modify-in-place behavior, which matches that of its legacy version.
+ * At present, callers of this function have no code to handle error conditions that might arise here.
+ * Because there's no error handling, therefore, this masks failures in UrlUnescape.
+ */
+void UnescapeUrl(std::wstring& url);
+