Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(969)

Issue 5734493784637440: Issue 245 - Unify SSL configuration for all servers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by Wladimir Palant
Modified:
5 years, 7 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Massive patch but it is mostly straightforward. As far as functionality of the hosts goes, this merely makes easylist-msie.adblockplus.org a proper alias of easylist-downloads.adblockplus.org (switching to wildcard certificate was required for that).

Patch Set 1 #

Total comments: 2

Patch Set 2 : Converted Nagios site configuration and centralized error page configuration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -800 lines) Patch
M manifests/codereviewserver.pp View 1 chunk +2 lines, -1 line 0 comments Download
M manifests/downloadserver.pp View 1 chunk +6 lines, -1 line 0 comments Download
M manifests/monitoringserver.pp View 1 1 chunk +2 lines, -1 line 0 comments Download
M manifests/statsserver.pp View 1 chunk +6 lines, -1 line 0 comments Download
M manifests/updateserver.pp View 1 chunk +6 lines, -1 line 0 comments Download
R modules/discourse/files/logrotate View 1 chunk +0 lines, -11 lines 0 comments Download
M modules/discourse/files/site.conf View 1 1 chunk +38 lines, -67 lines 0 comments Download
M modules/discourse/manifests/init.pp View 1 chunk +9 lines, -25 lines 0 comments Download
R modules/downloadserver/files/logrotate View 1 chunk +0 lines, -11 lines 0 comments Download
M modules/downloadserver/files/site.conf View 1 1 chunk +20 lines, -42 lines 0 comments Download
M modules/downloadserver/manifests/init.pp View 2 chunks +11 lines, -27 lines 0 comments Download
R modules/filterserver/files/logrotate View 1 chunk +0 lines, -11 lines 0 comments Download
M modules/filterserver/files/site.conf View 1 1 chunk +6 lines, -37 lines 0 comments Download
M modules/filterserver/manifests/init.pp View 1 chunk +6 lines, -23 lines 0 comments Download
M modules/nagios/files/site.conf View 1 1 chunk +33 lines, -52 lines 0 comments Download
M modules/nagios/manifests/server.pp View 1 2 chunks +14 lines, -30 lines 0 comments Download
M modules/nginx/manifests/init.pp View 1 chunk +62 lines, -24 lines 0 comments Download
A modules/nginx/templates/logrotate.erb View 1 chunk +11 lines, -0 lines 0 comments Download
A modules/nginx/templates/site.erb View 1 1 chunk +81 lines, -0 lines 0 comments Download
R modules/notificationserver/files/logrotate View 1 chunk +0 lines, -11 lines 0 comments Download
M modules/notificationserver/files/site.conf View 1 1 chunk +6 lines, -42 lines 0 comments Download
M modules/notificationserver/manifests/init.pp View 1 chunk +5 lines, -25 lines 0 comments Download
M modules/rietveld/files/site.conf View 1 1 chunk +3 lines, -6 lines 0 comments Download
M modules/rietveld/manifests/init.pp View 2 chunks +10 lines, -4 lines 0 comments Download
R modules/statsmaster/files/logrotate View 1 chunk +0 lines, -11 lines 0 comments Download
M modules/statsmaster/files/site.conf View 1 1 chunk +26 lines, -44 lines 0 comments Download
M modules/statsmaster/manifests/init.pp View 2 chunks +10 lines, -27 lines 0 comments Download
M modules/trac/files/site.conf View 1 chunk +9 lines, -42 lines 0 comments Download
modules/trac/manifests/init.pp View 1 chunk +5 lines, -22 lines 0 comments Download
R modules/updateserver/files/logrotate View 1 chunk +0 lines, -11 lines 0 comments Download
M modules/updateserver/files/site.conf View 1 1 chunk +2 lines, -25 lines 0 comments Download
M modules/updateserver/manifests/init.pp View 2 chunks +10 lines, -27 lines 0 comments Download
M modules/web/manifests/server.pp View 1 chunk +6 lines, -16 lines 0 comments Download
A modules/web/templates/global.conf.erb View 1 chunk +21 lines, -0 lines 0 comments Download
M modules/web/templates/site.conf.erb View 1 chunk +66 lines, -122 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
5 years, 7 months ago (2014-04-02 14:05:31 UTC) #1
Felix Dahlke
LGTM, nice to finally have this unified! Some remarks, I don't mind if these are ...
5 years, 7 months ago (2014-04-09 18:13:25 UTC) #2
Wladimir Palant
The new patchset contains mostly whitespace changes to address the comments. In addition to that ...
5 years, 7 months ago (2014-04-10 06:46:28 UTC) #3
Felix Dahlke
5 years, 7 months ago (2014-04-10 07:42:49 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5