Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(117)

Issue 5734888082767872: Issue #580 - "Disable on this page only" should discard the final # from URLs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by saroyanm
Modified:
5 years, 8 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This issue is related to current ticket: https://issues.adblockplus.org/ticket/580

Patch Set 1 #

Total comments: 2

Patch Set 2 : assign empty string to location.ref #

Total comments: 2

Patch Set 3 : check for nsIURI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/ui.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
saroyanm
Wladimir can you please have a look when you have time, should be quick one, ...
5 years, 8 months ago (2014-06-11 16:33:38 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5734888082767872/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5734888082767872/diff/5629499534213120/lib/ui.js#newcode1508 lib/ui.js:1508: location.spec.substring(0, location.spec.length - 1) : location.spec); The code setting ...
5 years, 8 months ago (2014-06-12 06:40:08 UTC) #2
saroyanm
Hope we can give a go now. http://codereview.adblockplus.org/5734888082767872/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5734888082767872/diff/5629499534213120/lib/ui.js#newcode1508 lib/ui.js:1508: location.spec.substring(0, location.spec.length ...
5 years, 8 months ago (2014-06-12 07:19:06 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5734888082767872/diff/5649050225344512/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5734888082767872/diff/5649050225344512/lib/ui.js#newcode1507 lib/ui.js:1507: location.ref = ""; Please don't remove |location instanceof Ci.nsIURL| ...
5 years, 8 months ago (2014-06-12 08:09:36 UTC) #4
saroyanm
http://codereview.adblockplus.org/5734888082767872/diff/5649050225344512/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5734888082767872/diff/5649050225344512/lib/ui.js#newcode1507 lib/ui.js:1507: location.ref = ""; On 2014/06/12 08:09:36, Wladimir Palant wrote: ...
5 years, 8 months ago (2014-06-12 14:20:39 UTC) #5
Wladimir Palant
5 years, 8 months ago (2014-06-12 18:07:27 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5