Issue #580 - "Disable on this page only" should discard the final # from URLs

lib/ui.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1486 matching lines @@
       let host = null;
       try
       {
         host = location.host.replace(/^www\./, "");
       } catch (e) {}
 
       if (host)
       {
         let ending = "|";
         location = location.clone();
+        location.spec = (location.spec.indexOf("#", location.spec.length - 1) ? 
+                         location.spec.substring(0, location.spec.length - 1) : location.spec);

[Wladimir Palant, 2014/06/12 06:40:08]

The code setting location.ref right below the one you added is responsible for
removing the hash part of the URL - you should fix that one rather than adding a
hack. Apparently, location.ref is "" both when the hash part is missing and when
it is just #. However, if we just assign an empty string to it without checking
whether it was already empty before it should always work.

For reference:
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interfa...

[saroyanm, 2014/06/12 07:19:06]

Good point, how I could miss that easy change.
Done.

         if (location instanceof Ci.nsIURL && location.ref)
           location.ref = "";
         if (location instanceof Ci.nsIURL && location.query)
         {
           location.query = "";
           ending = "?";
         }
 
         siteWhitelist = Filter.fromText("@@||" + host + "^$document");
         setChecked(prefix + "whitelistsite", siteWhitelist.subscriptions.length && !siteWhitelist.disabled);
@@ skipping 433 matching lines @@
   ["abp-command-contribute", "command", UI.openContributePage.bind(UI)],
   ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)]
 ];
 
 onShutdown.add(function()
 {
   for (let window in UI.applicationWindows)
     if (UI.isBottombarOpen(window))
       UI.toggleBottombar(window);
 });