Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/ui.js

Issue 5734888082767872: Issue #580 - "Disable on this page only" should discard the final # from URLs (Closed)
Patch Set: Created June 11, 2014, 4:31 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/ui.js
===================================================================
--- a/lib/ui.js
+++ b/lib/ui.js
@@ -1504,6 +1504,8 @@
{
let ending = "|";
location = location.clone();
+ location.spec = (location.spec.indexOf("#", location.spec.length - 1) ?
+ location.spec.substring(0, location.spec.length - 1) : location.spec);
Wladimir Palant 2014/06/12 06:40:08 The code setting location.ref right below the one
saroyanm 2014/06/12 07:19:06 Good point, how I could miss that easy change. Don
if (location instanceof Ci.nsIURL && location.ref)
location.ref = "";
if (location instanceof Ci.nsIURL && location.query)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld