#753 - set up an order system to let eyeo employees file order requests

modules/trac/manifests/init.pp

 class trac(
     $domain,
     $certificate,
     $private_key,
-    $permissions = "puppet:///modules/trac/permissions.csv",

[Wladimir Palant, 2014/07/22 13:52:24]

Shouldn't this be an instance parameter? While this file needs to be applied
manually, we probably want to have both versions installed in obvious locations.

+    $fcgi_config_dir = '/etc/nginx/trac.d',
     $is_default = false) inherits private::trac {
 
   package {['python-mysqldb','python-pip','subversion', 'tofrodos', 'graphviz']:
     ensure => present
   }
 
   include nginx, spawn-fcgi
 
+  file {$fcgi_config_dir:
+    ensure => directory,
+    owner => 'root',
+    mode => 755,
+    require => Package['nginx'],
+  }
+
   nginx::hostconfig {$domain:
-    source => 'puppet:///modules/trac/site.conf',

[mathias, 2014/07/24 16:36:49]

What about a directory to write the necessary fragments to and then include them
in the site.conf? E.g. /home/trac/nginx-site.d or something like that.

+    content => "include $fcgi_config_dir/*;",
     is_default => $is_default,
     certificate => $certificate,
     private_key => $private_key,
-    log => 'access_log_trac'
+    log => 'access_log_trac',
+    require => File[$fcgi_config_dir],
   }
 
   user {'trac':
     ensure => present,
     comment => 'User of the trac installation',
     home => '/home/trac',
     managehome => true
   }
 
   class {'mysql::server':
     root_password => $database_root_password,
-    override_options => {
-      'mysqld' => { 'federated' => true },
-    },
-    restart => true,
   }
 
   Exec {
     path => '/usr/bin:/usr/sbin:/bin:/usr/local/bin',
   }
 
   exec { 'install_trac':
     command => "pip install Trac==1.0.1",
     require => Package['python-pip'],
     unless => "python -c 'import trac,sys;sys.exit(0 if trac.__version__ == \"1.0.1\" else 1)'",
@@ skipping 58 matching lines @@
         'python-pip'],
     unless => "python -c 'import tracspamfilter'",
   }
 
   exec { 'install_Tractags':
     command => "pip install svn+http://trac-hacks.org/svn/tagsplugin/tags/0.7/",
     require => Package['python-pip'],
     unless => "python -c 'import tractags'",
   }
 
-  file {"/home/trac/permissions.csv":
+  exec { 'install_PrivateTickets':
+    command => "pip install svn+http://trac-hacks.org/svn/privateticketsplugin/tags/2.0.2/",
+    require => Package['subversion', 'python-pip'],
+    unless => "python -c 'import privatetickets'",
+  }
+
+  file { '/home/trac/trac.ini':
     ensure => present,
-    owner => trac,
-    source => $permissions,
+    source => 'puppet:///modules/trac/trac.ini',
+    owner => 'trac',
+    mode => 644,
   }
 
   define instance (
       $config = 'trac/trac.ini.erb',
       $description = 'Issue Tracker',
-      $environment = 'environment',
       $location = '/',
-      $logo = 'eyeo_logo.png',
+      $logo = 'puppet:///modules/trac/logo.png',
       $database = 'trac',
-      $database_password = $private::trac::database_password,
+      $permissions = 'puppet:///modules/trac/permissions.csv',
       $theme = 'puppet:///modules/trac/theme.css') {
+
+    $database_password = $private::trac::database_password
+    $environment = "environment-$name"
  
     mysql::db {$database:
       user => 'trac',
       password => $database_password,
       host => 'localhost',
       grant => ['all'],
       charset => 'utf8',
       collate => 'utf8_bin',
       require => Class['mysql::server'],
     }
-  
-    exec {"trac_env_$name":
-      command => "trac-admin /home/trac/$environment initenv \"$description\" mysql://trac:${database_password}@localhost:3306/$database",

[Wladimir Palant, 2014/07/31 09:46:53]

Indeed, didn't know it existed. We should use that consistently whenever we are
generating shell commands.

+
+    $location_base = regsubst($location, '/+$', '')
+
+    file {"${trac::fcgi_config_dir}/${name}.conf":
+      ensure => file,
+      owner => 'root',
+      mode => 644,
+      content => template('trac/fcgi.conf.erb'),
+      require => File[$trac::fcgi_config_dir],
+      notify => Service['nginx'],
+    }
+  
+    exec {"trac_env_${name}":
+      command => shellquote(
+        'trac-admin', "/home/trac/$environment", 'initenv', $description,
+        "mysql://trac:${database_password}@localhost:3306/$database"),
+      logoutput => true,
       path => '/usr/bin:/usr/sbin:/bin:/usr/local/bin',
       require => [
         Exec['install_trac'],
-        Mysql_grant["trac@localhost/$database.*"]
-      ],
-      user => trac,
-      unless => "test -d /home/trac/$environment"
+        Mysql_grant["trac@localhost/${database}.*"]],
+      user => trac,
+      unless => "test -d /home/trac/$environment",
+    }
+
+    file {"/home/trac/${environment}/conf/permissions.csv":
+      ensure => present,
+      owner => trac,
+      source => $permissions,
+      require => Exec["trac_env_$name"],
     }
   
     file {"/home/trac/$environment/conf/trac.ini":
       ensure => present,
       content => template($config),
       owner => trac,
       require => Exec["trac_env_$name"]
     }
   
     file {"/home/trac/$environment/htdocs/theme.css":
@@ skipping 11 matching lines @@
         File["/home/trac/$environment/conf/trac.ini"],
         Exec['install_SensitiveTickets'],
         Exec['install_BlackMagicTicketTweaks'],
         Exec['install_AccountManager'],
         Exec['install_AutocompleteUsers'],
         Exec['install_TicketTemplate'],
         Exec['install_NeverNotifyUpdater'],
         Exec['install_MasterTickets'],
         Exec['install_ThemeEngine'],
         Exec['install_Tractags'],
-        Exec['install_TracSpamFilter']]
+        Exec['install_TracSpamFilter'],
+        Exec['install_PrivateTickets']],
     }
   
     exec {"deploy_$name":
-      command => "trac-admin /home/trac/$environment deploy /home/trac/htdocs && fromdos /home/trac/htdocs/cgi-bin/trac.fcgi && chmod 755 /home/trac/htdocs/cgi-bin/trac.fcgi",
+      command => "trac-admin /home/trac/$environment \
+        deploy /home/trac/htdocs-$name \
+        && fromdos /home/trac/htdocs-$name/cgi-bin/trac.fcgi \
+        && chmod 755 /home/trac/htdocs-$name/cgi-bin/trac.fcgi",
       user => trac,
       path => '/usr/bin:/usr/sbin:/bin:/usr/local/bin',
       require => [
         Exec["update_env_$name"],
-        Package["tofrodos"]]
-    }
-  
-    file {"/home/trac/htdocs/htdocs/common/$logo":
-      ensure => present,
-      source => "puppet:///modules/trac/$logo",
+        Package["tofrodos"]],
+    }
+  
+    file {"/home/trac/htdocs-$name/htdocs/common/logo.png":
+      ensure => present,
+      source => $logo,
       owner => trac,
       require => Exec["deploy_$name"],
     }
 
-    file {"/home/trac/htdocs/cgi-bin/trac.fcgi.$name":
-      ensure => present,
-      owner => trac,
-      mode => 774,
-      content => "#!/bin/sh
-        SCRIPT=`dirname \$0`/`basename \$0 .$name`
-        TRAC_ENV=/home/trac/$environment \$SCRIPT \"\$@\"

[Wladimir Palant, 2014/07/22 13:52:24]

This hack is only necessary because of reusing the same deployment directory,
see above.

-      ",
-      require => Exec["deploy_$name"],
-    }
-
-    spawn-fcgi::pool {"tracd_$name":
-      ensure => present,
-      fcgi_app => "/home/trac/htdocs/cgi-bin/trac.fcgi.$name",
+    spawn-fcgi::pool {"tracd_${name}":
+      ensure => present,
+      fcgi_app => "/home/trac/htdocs-$name/cgi-bin/trac.fcgi",
       socket => "/tmp/${name}-fastcgi.sock",
       mode => "0666",
       user => trac,
       children => 1,
-      require => File["/home/trac/htdocs/cgi-bin/trac.fcgi.$name"],
-    }
-
+      require => Exec["deploy_$name"],
+    }
   }
 }