Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(400)

Issue 5738402414592000: Issue 1602 - Pass array directly from backupCustomFilters() to IO.writeToFile() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Sebastian Noack
Modified:
4 years, 9 months ago
Visibility:
Public.

Description

Since we are using for..of instead for..in inside IO.wirteToFile() now, we can pass arrays as well as generators, and don't need to wrap the former into the latter anymore.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/content/ui/filters-backup.js View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
4 years, 9 months ago (2015-04-02 17:03:23 UTC) #1
Sebastian Noack
4 years, 9 months ago (2015-04-13 10:37:16 UTC) #2
tschuster
4 years, 9 months ago (2015-04-14 09:48:05 UTC) #3
On 2015/04/13 10:37:16, Sebastian Noack wrote:

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5