Issue 5739851907334144: Update browser actions everytime filters are loaded or saved

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5739851907334144: Update browser actions everytime filters are loaded or saved (Closed)

Created:
Feb. 24, 2014, 4:17 p.m. by Sebastian Noack

Modified:
Feb. 28, 2014, 8:14 a.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

Currently the ABP icon on Chrome is only updated on startup for all tabs and when you disable/enable ABP for the current page in the bubble. However updating the icon on startup is completely useless, because filters aren't loaded, and we don't know about whitelisted pages yet. Also when you enable/disable ABP for a given domain, the icon isn't updated for other open tabs showing a page from that domain. So we have to update browser actions for all tabs every time filters were loaded or changes to the filters were saved.

Patch Set 1 #

Created: Feb. 24, 2014, 4:17 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	background.js	View		2 chunks	+16 lines, -12 lines	0 comments	Download
	M	popup.js	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages