Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: chrome/skin/abp-status-32.png
Issue
5741004535627776
:
Fix toolbar icon customization in Australis (Closed)
Patch Set: Added 32x32 icon and fixed my own review comments
Created Dec. 2, 2013, 10:55 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Fixed unintentional code duplication
Patch Set 3: Got rid of repeated require() calls
Patch Set 4: Fixed icon`s menu initialization when the icon is inside the Australis panel
Patch Set 5: Improved approach (custom button type), marked our custom API extensions
Patch Set 6: Added 32x32 icon and fixed my own review comments
Right:
Patch Set 1: None
Patch Set 2: Fixed unintentional code duplication
Patch Set 3: Got rid of repeated require() calls
Patch Set 4: Fixed icon`s menu initialization when the icon is inside the Australis panel
Patch Set 5: Improved approach (custom button type), marked our custom API extensions
Patch Set 6: Added 32x32 icon and fixed my own review comments
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
chrome/content/ui/overlay.xul
chrome/content/ui/settings.xul
chrome/locale/en-US/overlay.dtd
chrome/skin/abp-status-32.png
chrome/skin/overlay.css
lib/appSupport.js
lib/customizableUI.js
lib/ui.js
metadata.gecko
View unified diff
|
Download patch
« chrome/content/ui/settings.xul
('K') |
« chrome/locale/en-US/overlay.dtd
('k') |
chrome/skin/overlay.css »
('j') |
lib/appSupport.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« chrome/content/ui/settings.xul
('K') |
« chrome/locale/en-US/overlay.dtd
('k') |
chrome/skin/overlay.css »
('j') |
lib/appSupport.js »
('J')
Edit Message
Issue 5741004535627776: Fix toolbar icon customization in Australis (Closed)
Created Nov. 22, 2013, 5:06 p.m. by Wladimir Palant
Modified Sept. 15, 2016, 12:18 p.m.
Reviewers: Felix Dahlke, tschuster
Base URL:
Comments: 13
This is Rietveld