chrome/content/ui/firstRun.js - Issue 5743229060251648: Show warning about unsupported Safari version on first run page also for Safari 6.1 and 7.0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/ui/firstRun.js

Issue 5743229060251648: Show warning about unsupported Safari version on first run page also for Safari 6.1 and 7.0 (Closed)

Patch Set: Created Nov. 28, 2013, 11:36 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/content/ui/firstRun.js

===================================================================

--- a/chrome/content/ui/firstRun.js

+++ b/chrome/content/ui/firstRun.js

@@ -63,9 +63,13 @@

setLinks("dataCorruptionWarning", Utils.getDocLink("knownIssuesChrome_filterstorage"));

}

- // Show warning if Safari < 6

+ // Show warning if Safari version isn't supported

var info = require("info");

- if (info.platform == "safari" && Services.vc.compare(info.platformVersion, "6.0") < 0)

+ if (info.platform == "safari" && (

+ Services.vc.compare(info.platformVersion, "6.0") < 0 || // beforeload breaks websites in Safari 5

+ Services.vc.compare(info.platformVersion, "6.1") == 0 || // extensions are broken in 6.1 and 7.0

+ Services.vc.compare(info.platformVersion, "7.0") == 0

+ ))

E("legacySafariWarning").removeAttribute("hidden");

// Set up feature buttons linked to subscriptions

« no previous file with comments | « no previous file | chrome/locale/en-US/firstRun.properties » ('j') | no next file with comments »