Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/filterNotifier.js

Issue 5743624616673280: Issue 261 - FilterNotifier doesn`t support listeners removing themselves when triggered (Closed)
Patch Set: Created April 4, 2014, 12:46 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 * "subscription.added", "subscription.removed", 59 * "subscription.added", "subscription.removed",
60 * "subscription.disabled", "subscription.title", 60 * "subscription.disabled", "subscription.title",
61 * "subscription.lastDownload", "subscription.downloadStatus", 61 * "subscription.lastDownload", "subscription.downloadStatus",
62 * "subscription.homepage", "subscription.updated", 62 * "subscription.homepage", "subscription.updated",
63 * "filter.added", "filter.removed", "filter.moved", 63 * "filter.added", "filter.removed", "filter.moved",
64 * "filter.disabled", "filter.hitCount", "filter.lastHit") 64 * "filter.disabled", "filter.hitCount", "filter.lastHit")
65 * @param {Subscription|Filter} item item that the change applies to 65 * @param {Subscription|Filter} item item that the change applies to
66 */ 66 */
67 triggerListeners: function(action, item, param1, param2, param3) 67 triggerListeners: function(action, item, param1, param2, param3)
68 { 68 {
69 for each (let listener in listeners) 69 let list = listeners.slice();
70 for each (let listener in list)
70 listener(action, item, param1, param2, param3); 71 listener(action, item, param1, param2, param3);
71 } 72 }
72 }; 73 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld